allow cid format selection in block put command #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/block-cid-codec
branch
4 times, most recently
from
a3f2a34
to
ce3fd25
Compare
|
Shouldn't it be |
|
@Kubuxu what do you mean? |
|
You had to change the hashes in the tests, which means that hashes outputted by |
|
Ah, yeah. Youre referring to setting the default format value to be "v0". That makes sense to me. |
whyrusleeping
force-pushed
the
feat/block-cid-codec
branch
from
ce3fd25
to
f68e184
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
|
@Kubuxu there, now the default behaviour doesnt change. Good catch |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy why@ipfs.io