Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework add-mfs to not use caching #2795

Merged
merged 1 commit into from
Jun 7, 2016
Merged

rework add-mfs to not use caching #2795

merged 1 commit into from
Jun 7, 2016

Conversation

whyrusleeping
Copy link
Member

License: MIT
Signed-off-by: Jeromy why@ipfs.io

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping whyrusleeping added the need/review Needs a review label Jun 3, 2016
@ghost
Copy link

ghost commented Jun 5, 2016

What's the symlink-related change in this commit?

@hackergrrl
Copy link
Contributor

@lgierth: this PR is a cleaner stab at #2690, which has a bit more history on why symlinks are relevant to this. My understanding is that mfs doesn't support symlinks but since ipfs add uses mfs we need to support symlink caching to get the correct dag back.

@whyrusleeping
Copy link
Member Author

@lgierth its a workaround for the fact that mfs doesnt support symlinks, but we support ipfs add'ing symlinks. You can construct a tree with them in it, but you won't be able to use them via the files api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants