Add check for HEAD response to be empty #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
| @@ -116,6 +116,11 @@ test_expect_success "output looks good" ' | |||
| grep "Content-Type: text/html" indexout | |||
| ' | |||
|
|
|||
| test_expect_success "HEAD 'index.html' has no content" ' | |||
| curl -X HEAD --max-time 1 http://127.0.0.1:$port/ipfs/$INDEXHASH/ > output; | |||
There was a problem hiding this comment.
should have an && between these. otherwise this will pass if the curl command fails
There was a problem hiding this comment.
The curl will fail as for the timeout because curl won't terminate if you use -X HEAD it will wait for the rest of response that should not be coming.
There was a problem hiding this comment.
Because this test is to check if head request has no content. --head won't return the content even if it is there.
There was a problem hiding this comment.
Ah, makes sense. Carry on!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2194
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch