Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Determine v1 schema #8

Closed
petar opened this issue Dec 7, 2021 · 5 comments
Closed

Determine v1 schema #8

petar opened this issue Dec 7, 2021 · 5 comments
Assignees
Milestone

Comments

@petar
Copy link
Contributor

petar commented Dec 7, 2021

Done Criteria

There is a schema that Go IPFS Stewards (go-ipfs) and Data Systems (storethesytem) agree on and is checked in. Basically, with what we know today, are there any changes that should be made to the schema? If so, they should get be checked in.

Why Important

Enables client and server implementations to be worked on and deployed independently without fear that there will be breaking changes. This is needed for ipfs/kubo#8775.

Notes

This v1 schema should be set in light of what have learned from delegated routing conversations with storetheindex. The schema should be set based on what is believed to be best for delegated-routing, but should be informed of real usecases.

As part of this discussion, we should be clear about where the "Filecoin records" are getting filtered out: a) on the Indexer implementation of "findproviders" or b) on the client side (e.g., Hydra, go-ipfs) after getting the "findproviders" result.

There are existing / related PRs open around this:
#6
#7

@willscott
Copy link
Contributor

I left my comments in #6 a bit ago, but the main things I'd like to see in the shared schema are:

  • extended / additional struct defining filecoin graphsync as an additional protocol to bitswap
  • potentially a way in GetP2PProvideRequest for requests to specify which protocols they support.
    • The most natural options from my perspective at a protocol level are that either the client will request with a list of supported protocols and get back relevant (filtered) records, or the client will get back all records and filter them locally.

@BigLep
Copy link

BigLep commented Mar 9, 2022

I don't know yet when we'll pick this up. We're working on getting input from leadership on where we should focus. I am aiming to have more clarity on this by end of week (2022-03-11).

@BigLep BigLep changed the title Converge on shared schema for Hydra-Indexer and Indexer-Finder Determine v1 schema Mar 11, 2022
@BigLep
Copy link

BigLep commented Mar 22, 2022

2022-03-22 conversation: this is being acted on now. The plan is to write a ipfs/spec that will mostly be IPLD schema.

@aschmahmann
Copy link
Contributor

Spec PR ipfs/specs#272

@BigLep
Copy link

BigLep commented Apr 8, 2022

Resolving since ipfs/specs#272 was merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
4 participants