Ignored error in PeerSendWants

[Stebalien]

What happens if OK is false? Is this possible? Just ignoring the error and moving on seems like a bad idea.

go-bitswap/internal/peermanager/peerwantmanager.go

Lines 88 to 90 in 9b89a3b

	// Get the existing want-blocks and want-haves for the peer
	if pws, ok := pwm.peerWants[p]; ok {
	// Iterate over the requested want-blocks

[dirkmc]

In practice this shouldn't be possible. We add the peer to PeerWantManager as soon as we have a connection, and remove it as soon as the last connection is cleaned up:

go-bitswap/internal/peermanager/peermanager.go

Lines 94 to 99 in 9b89a3b

	// If this is the first connection to the peer
	if pq.refcnt == 1 {
	// Inform the peer want manager that there's a new peer
	pm.pwm.AddPeer(p)
	// Record that the want-haves are being sent to the peer
	pm.pwm.PrepareSendWants(p, nil, initialWantHaves)

go-bitswap/internal/peermanager/peermanager.go

Lines 119 to 129 in 9b89a3b

	if pq.refcnt > 0 {
	return
	}
	// Inform the sessions that the peer has disconnected
	pm.signalAvailability(p, false)
	// Clean up the peer
	delete(pm.peerQueues, p)
	pq.pq.Shutdown()
	pm.pwm.RemovePeer(p)