Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Hook not called if a test fails #704

Closed
vasco-santos opened this issue Dec 22, 2020 · 0 comments · Fixed by #737
Closed

Post Hook not called if a test fails #704

vasco-santos opened this issue Dec 22, 2020 · 0 comments · Fixed by #737
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@vasco-santos
Copy link
Member

Desktop:

  • OS: [e.g. iOS] MacOS
  • Version [e.g. 22] 30.2.0 (latest)

When running tests using aegir with pre and post hooks, if any test fails the post hook is not being called.

This causes problems as other services might not be properly stopped and follow up tests will fail unless services are manually teared down.
@vasco-santos vasco-santos added the kind/bug A bug in existing code (including security flaws) label Dec 22, 2020
@hugomrdias hugomrdias mentioned this issue Feb 23, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release v31 ipfs/aegir
1 participant
@vasco-santos