Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of typescript source / transpiled javascript #596

Closed
wemeetagain opened this issue Jun 25, 2020 · 0 comments · Fixed by #737
Closed

Location of typescript source / transpiled javascript #596

wemeetagain opened this issue Jun 25, 2020 · 0 comments · Fixed by #737

Comments

@wemeetagain
Copy link
Member

IMO it seems strange to have transpiled javascript in a different directory than src/. The reason is that aegir-maintained libp2p repos (non-typescript repos) expect javascript source files to be in src, and submodules are sometimes directly imported like eg: require('libp2p-xxx/src/submodule')). If typescript aegir-maintained projects are to maximally maintain compatibility with non-typescript aegir-maintained projects, it seems that we would want to maintain this project structure?

Originally posted by @wemeetagain in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjc1ODE3ODM5OnYy/pull_request_review_threads/discussion

@hugomrdias hugomrdias mentioned this issue Feb 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant