Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Check for tildes and carrots in package.json #101

Closed
RichardLitt opened this issue Feb 10, 2017 · 2 comments
Closed

Feat: Check for tildes and carrots in package.json #101

RichardLitt opened this issue Feb 10, 2017 · 2 comments
Labels
aegir.next help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@RichardLitt
Copy link
Member

Every module below 1.0.0 should use ~ instead of ^. Aegir should check for this.

See ipfs/community#237 (comment).
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Feb 10, 2017
@dignifiedquire
Copy link
Member

https://github.com/tclindner/npm-package-json-lint should be able to help us here. But we need to write a custom rule to differentiate between pre and post 1.0

@dignifiedquire dignifiedquire added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Mar 8, 2017
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Apr 5, 2017
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jun 21, 2017
@daviddias daviddias mentioned this issue Jul 5, 2017
Merged
25 tasks
@dignifiedquire
Copy link
Member

img_2451

As you can see this is actually not needed. Semver does the right thing for pre 1.0 releases with carets already.

@dignifiedquire dignifiedquire removed the status/deferred Conscious decision to pause or backlog label Jul 8, 2017
@achingbrain achingbrain mentioned this issue Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aegir.next help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dignifiedquire @RichardLitt @daviddias