Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): set status bar animation style when showing and hiding #2587

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

sbannigan
Copy link
Contributor

This adds an option to the status bar show and hide methods to change the animation style. The style will always default to .slide if not specified in the options (other options are .fade and .none. This is iOS only. I considered adding this as a plugin config that could be configured in capacitor.config.json but there could be use cases to change this on each show and hide.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor change

@sbannigan
Copy link
Contributor Author

change made!

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was fast, thanks!

@jcesarmobile jcesarmobile merged commit fa6bb3e into master Mar 19, 2020
@jcesarmobile jcesarmobile deleted the feat/ios-status-bar-animation branch March 19, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants