chore(ios): drop Xcode 10 support (#2472)

ionic-team · Feb 24, 2020 · 255a046 · 255a046
1 parent afd8554
commit 255a046
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/ios-template/App/Podfile b/ios-template/App/Podfile
@@ -1,7 +1,7 @@
 platform :ios, '11.0'
 use_frameworks!
 
-# workaround to avoid Xcode 10 caching of Pods that requires
+# workaround to avoid Xcode caching of Pods that requires
 # Product -> Clean Build Folder after new Cordova plugins installed
 # Requires CocoaPods 1.6 or newer
 install! 'cocoapods', :disable_input_output_paths => true

diff --git a/ios/Capacitor/Capacitor/CAPBridgeViewController.swift b/ios/Capacitor/Capacitor/CAPBridgeViewController.swift
@@ -201,8 +201,9 @@ public class CAPBridgeViewController: UIViewController, CAPBridgeDelegate, WKScr
       if let statusBarStyle = plist["UIStatusBarStyle"] as? String {
         if (statusBarStyle == "UIStatusBarStyleDarkContent") {
           if #available(iOS 13.0, *) {
-            // TODO - use .darkContent instead of rawValue once Xcode 10 support is dropped
-            self.statusBarStyle = UIStatusBarStyle.init(rawValue: 3) ?? .default
+            self.statusBarStyle = .darkContent
+          } else {
+            self.statusBarStyle = .default
           }
         } else if (statusBarStyle != "UIStatusBarStyleDefault") {
           self.statusBarStyle = .lightContent

diff --git a/ios/Capacitor/Capacitor/Plugins/StatusBar.swift b/ios/Capacitor/Capacitor/Plugins/StatusBar.swift
@@ -21,8 +21,7 @@ public class CAPStatusBarPlugin: CAPPlugin {
         bridge.setStatusBarStyle(.lightContent)
       } else if style == "LIGHT" {
         if #available(iOS 13.0, *) {
-          // TODO - use .darkContent instead of rawValue once Xcode 10 support is dropped
-          bridge.setStatusBarStyle(UIStatusBarStyle.init(rawValue: 3) ?? .default)
+          bridge.setStatusBarStyle(.darkContent)
         } else {
           bridge.setStatusBarStyle(.default)
         }

diff --git a/site/docs-md/basics/opening-native-projects.md b/site/docs-md/basics/opening-native-projects.md
@@ -11,7 +11,7 @@ contributors:
 
 <p class="intro">Capacitor uses the native IDE for each platform in order to provide required configuration, and to build, test, and deploy apps.</p>
 
-<p class="intro">For iOS development, that means you must have <a href="https://developer.apple.com/xcode/" target="_blank">Xcode 10</a> or above installed. For Android, <a href="https://developer.android.com/studio/index.html" target="_blank">Android Studio</a> 3 or above.</p>
+<p class="intro">For iOS development, that means you must have <a href="https://developer.apple.com/xcode/" target="_blank">Xcode 11</a> or above installed. For Android, <a href="https://developer.android.com/studio/index.html" target="_blank">Android Studio</a> 3 or above.</p>
 
 <p class="intro">Both IDEs can be opened manually or using the <code>npx cap open</code> command:</p>
 

diff --git a/site/docs-md/getting-started/dependencies.md b/site/docs-md/getting-started/dependencies.md
@@ -21,7 +21,7 @@ For specific platforms, follow each guide below to ensure you have the correct d
 
 ## iOS Development
 
-For building iOS apps, Capacitor requires a **Mac with Xcode 10 or above**. Soon, you'll be able to use [Ionic Appflow](http://ionicframework.com/appflow) to build for iOS even if you're on Windows.
+For building iOS apps, Capacitor requires a **Mac with Xcode 11 or above**. Soon, you'll be able to use [Ionic Appflow](http://ionicframework.com/appflow) to build for iOS even if you're on Windows.
 
 Additionally, you'll need to install **[CocoaPods](https://cocoapods.org/)** (`sudo gem install cocoapods`), and install the **Xcode Command Line tools** (either from Xcode, or running `xcode-select --install`).
 

diff --git a/site/docs-md/guides/push-notifications-firebase.md b/site/docs-md/guides/push-notifications-firebase.md
@@ -284,7 +284,7 @@ Your `Podfile` should look something like this:
 platform :ios, '11.0'
 use_frameworks!
 
-# workaround to avoid Xcode 10 caching of Pods that requires
+# workaround to avoid Xcode caching of Pods that requires
 # Product -> Clean Build Folder after new Cordova plugins installed
 # Requires CocoaPods 1.6 or newer
 install! 'cocoapods', :disable_input_output_paths => true

diff --git a/site/docs-md/ios/index.md b/site/docs-md/ios/index.md
@@ -15,7 +15,7 @@ contributors:
 
 ## Getting Started
 
-Building iOS apps requires some iOS development dependencies to be installed, including Xcode 10 and the Xcode command line tools.
+Building iOS apps requires some iOS development dependencies to be installed, including Xcode 11 and the Xcode command line tools.
 
 Note: It's possible to develop and build iOS apps without a mac, such as by using Ionic Appflow's Package service. Consult your service of choice for more information.