Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group endpoints #1327

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Group endpoints #1327

merged 3 commits into from
Jan 11, 2022

Conversation

asgothian
Copy link
Collaborator

This is the first half of a bigger rework of the group handling in the zigbee adapter: The following parts are complete:

  • Allow for specific endpoints to be added to a group (up to 4 endpoints per device supported currently)
  • Modified Group updating - Just add / remove the desired entities rather than clearing a the entity from all groups and adding it back in
  • device.groups state is now obsolete - the group selection is based on the data taken from the groups as defined by the zigbee-herdsman. Note: The device.groups state is still present as the information contained is still used to list the groups on the device card.
  • Update the member display in the groups to contain the endpoint information
  • locked the group ID when editing a group.

Still to do:

  • streamline the data collection for the admin
  • enable group membership display on the device based on the data stored in the zigbee-herdsman
  • allow removal of devices from the groups via the groups 'edit' dialog.
  • automatic removal of device.groups state once it is no longer in use. Optional alternative: Update the device.groups state with the correct information from the zigbee-herdsman at adapter start as well as when changing group assignment.

Non Group-related changes:
Changed the level of the messages generated around the SetState_typed function from warning to debug.

Note: I am not entirely happy with the changes to index_m.html and tab_m.html, but lack of experience with UI elements had me taken the current brute force method for offering additional choices. A more dynamic option to generate the additional selection options for further endpoints would be preferable, but outside of what i can achieve at this point.

Allow user to select endpoint to join to group.
Fix device handling:
- show devices on groups based on the herdsman info
- ignore the device.group state
- selectively add and remove single devices from groups, instead of deleting all groups and adding anew.

Note: Group membership display on devices is currently not working. Will be fixed in future updates.

- Remove warn messages generated by type conversion.
@lgtm-com
Copy link

lgtm-com bot commented Jan 10, 2022

This pull request introduces 8 alerts when merging 978dc69 into 6048926 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class
  • 2 for Missing variable declaration

@asgothian
Copy link
Collaborator Author

asgothian commented Jan 10, 2022

Please do not merge - i updated my repository to remove the failed checks, but won't be able to test until this evening (Mon Jan 10th). I'll update once this is no longer needed.
Tests are done. It works.

@arteck if you have no objections, and as @kirovilya gave it a thumbs up i would merge this (or you do)

A.

@arteck
Copy link
Collaborator

arteck commented Jan 10, 2022

from here.. go.

@arteck arteck merged commit c3b4c79 into ioBroker:master Jan 11, 2022
@asgothian asgothian deleted the GroupEndpoints branch September 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants