forked from Yubico/yubikey-val-dpkg
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
3704 lines (2041 loc) · 110 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2022-09-08 Ronny Lindner <ronny.lindner@invia.de>
* NEWS: NEWS for 2.40
* Enhanced data validation to address YSA-2020-01.
* Re-indent everything according to PEAR standard.
2016-11-01 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: NEWS for 2.39
2016-08-17 Klas Lindfors <klas@yubico.com>
* doc/Generating_Clients.adoc: add a note about client
synchronization fixes #42
2016-06-08 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: Bump versions.
2016-06-08 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: NEWS for 2.38
2016-06-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Silence php notice. - cast curl handle to integer prior to using it as an array key.
2016-05-17 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: Bump versions.
2016-05-17 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: NEWS for 2.37
2016-05-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor.
2016-05-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor. - unset temporary variable.
2016-05-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Fix. - $request was never set if both $_POST and $_GET are empty!
2016-05-16 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: Bump versions.
2016-05-16 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: NEWS for 2.36
2016-05-09 Klas Lindfors <klali@avm.se>
* : Merge pull request #39 from
paulmenzel/grant-insert-and-update-rights-to-db-user-ykval_verifier doc/Installation: Grant insert and update rights to `ykval_verifier`
2016-04-29 Klas Lindfors <klas@yubico.com>
* .travis.yml: add php 7.0 for travis
2016-04-29 Klas Lindfors <klas@yubico.com>
* ykval-common.php, ykval-sync.php, ykval-verify.php: make
getHttpVal() take the array to extract from refactor so verify early finds out which of $_GET and $_POST to use
and then stick to using only that for the entire flow. sync only works with GET anyways so use $_GET directly.
2016-04-29 Klas Lindfors <klas@yubico.com>
* ykval-synclib.php: use strtok() instead of explode() since we only
care about first element
2016-04-29 Klas Lindfors <klas@yubico.com>
* ykval-synclib.php: use different syntax to caputer first element
of explode() call apparently not supported in 5.3 to get first element directly
2016-04-29 Klas Lindfors <klas@yubico.com>
* ykval-synclib.php: rework re-sync to not use CURLOPT_PRIVATE relates #41
2016-04-19 Klas Lindfors <klas@yubico.com>
* Makefile, NEWS: bump version
2016-04-19 Klas Lindfors <klas@yubico.com>
* NEWS: news for 2.35
2016-04-19 Klas Lindfors <klas@yubico.com>
* Makefile: add ykval-log-verify.php to the install target
2016-04-19 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: Bump versions.
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: NEWS for 2.34
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log-verify.php, ykval-verify.php: Fix issue with $baseParam
value. - introduced recently in these log format changes. - require_once 'ykval-config.php in logformat() did not import, because it takes place in ykval-verify.php. - hence logformat() did not have $baseParams in scope, so we never write the log line. - refactor and set format outside the class itself.
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-config.php, ykval-log-verify.php, ykval-verify.php: Add sl
and timeout to request log variables.
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Make it clear that default will be a string
digit. - since getHttpVal casts to string anyway.
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid ambiguity with client id. - getHttpVal always returns a string, so always treat $client as a string in other checks.
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-config.php, ykval-log-verify.php, ykval-verify.php: Add tls
and protocol variables to request log.
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Rename variable.
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log-verify.php: Fix syntax errors introduced in previous
commit.
2016-04-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php, ykval-config.php, ykval-log-verify.php,
ykval-log.php, ykval-verify.php: Add a verify request log line. - Traditionally we wrote two lines for each ykval-verify.php call, 'Request:' and 'Response:'. - This commit allows us to log both request/response values in a
single line. - For backward compatibility, the old logging is kept in place. - To write this line to syslog, __YKVAL_VERIFY_LOGFORMAT__ needs to
be set.
2016-03-14 Klas Lindfors <klas@yubico.com>
* ykval-synclib.php: limit how many queued entries we get on each
run if there's more than 1000 queued we will get another 1000 on the
next run.
2016-03-07 Klas Lindfors <klas@yubico.com>
* ykval-synclib.php: put building syncurl in a function
2016-03-07 Klas Lindfors <klas@yubico.com>
* ykval-synclib.php: implement paralell syncing with curl_multi
2016-02-08 Paul Menzel <paul.menzel@giantmonkey.de>
* doc/Installation.adoc: doc/Installation: Grant insert and update
rights to ykval_verifier Currently, when following the installation instructions, the scripts
adding clients to the database don’t work as the user
`ykval_verifier` does not have any insert rights for the table
`clients`. ``` LOG_DEBUG:ykval-gen-clients:db:DB query is:SELECT id FROM
clients ORDER BY id DESC LIMIT 1 LOG_DEBUG:ykval-gen-clients:db:DB
query is: INSERT INTO clients
(id,active,created,secret,email,notes,otp) VALUES ('1', '1',
'1404359826','XXXXXXXXXXXXXXXXXXXXXXXX =','','','')
LOG_INFO:ykval-gen-clients:db:Database query error: Array ( [0] =>
42000 [1] => 1142 [2] => INSERT command denied to user
'ykval_verifier'@'localhost' for table 'clients' )
LOG_ERR:ykval-gen-clients:Failed to insert new client with query
INSERT INTO clients (id,active,created,secret,email,notes,otp)
VALUES ('1', '1',
'1404359826’,’XXXXXXXXXXXXXXXXXXXXXXXX=','','','') Failed to
insert new client with query INSERT INTO clients
(id,active,created,secret,email,notes,otp) VALUES ('1', '1',
'1404359826','XXXXXXXXXXXXXXXXXXXXXXXX =','','','')` ``` Therefore, update the documentation, to also grant the user
`ykval_verifier` the rights to insert and update records into the
table `clients`. No delete rights are granted, because there is an
`active` column, which should probably used over deletion of
clients. Note, the original idea was probably to use two database users. One
for inserting and updating data, and one for querying/validating it.
As, nothing is written about this though, use the
existing/recommended user for both things. Fixes: #20 (ykval_verifier SQL user doesn't have permission to
INSERT INTO clients, breaks ykval-gen-clients)
2016-02-05 Klas Lindfors <klali@avm.se>
* : Merge pull request #38 from
paulmenzel/improve-documentation-for-import-export-data Improve documentation for import export data
2016-02-04 Paul Menzel <paul.menzel@giantmonkey.de>
* doc/Import_Export_Data.adoc: doc/Import_Export_Data: Remove
trailing whitespace Run the command `StripWhitespace` from Vim Better Whitespace Plugin
[1]. [1] https://github.com/ntpeters/vim-better-whitespace
2016-01-07 Klas Lindfors <klali@avm.se>
* : Merge pull request #37 from
paulmenzel/add-install-command-for-non-deb-distributions doc/Installation: Add install commands for non-Debian distributions
2016-01-05 Klas Lindfors <klali@avm.se>
* : Merge pull request #36 from
paulmenzel/improve-installation-documentation Improve installation documentation
2015-12-23 Paul Menzel <paul.menzel@giantmonkey.de>
* doc/Installation.adoc: doc/Installation: Update Ubuntu
recommendation to 14.04 LTS Ubuntu 12.04 LTS will be supported until April 2017, but Ubuntu
14.04 LTS has been around long enough, so it’s well tested and
probably more common to install than 12.04 LTS. It’s supported
until April 2019 [1]. [1] https://wiki.ubuntu.com/Releases
2015-12-23 Paul Menzel <paul.menzel@giantmonkey.de>
* doc/Installation.adoc: doc/Installation: Fix wording to *The
following steps apply …*
2015-12-22 Klas Lindfors <klali@avm.se>
* : Merge pull request #35 from
paulmenzel/remove-trailing-whitespace-from-installation-documentationdoc/Installation: Remove trailing whitespace
2015-12-09 Jean Paul Galea <jp@galea.se>
* : Merge pull request #33 from
paulmenzel/fix-typo-in-comment-of-config-file ykval-config.php: Spell *addresses* correctly in comment
2015-12-08 Paul Menzel <paul.menzel@giantmonkey.de>
* ykval-config.php: ykval-config.php: Use *ksm* instead of *kms* Avoid confusion and use the correct spelling for the three letter
acronym KSM (Key Storage Module).
2015-12-08 Paul Menzel <paul.menzel@giantmonkey.de>
* ykval-config.php: ykval-config.php: Spell *addresses* correctly in
comment
2015-10-05 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: Bump versions.
2015-10-05 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: NEWS for 2.33
2015-09-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-config.php: Added localhost port 80 for ksm service. - previously the default config only included port 80. - this was changed in 382cfc2ab506a4c0f6ba0222d473ff3df77dd6f5, to avoid issues with yhsm-yubikey-ksm, which defaults to port 8002. - however, this broke configurations running with yubikey-ksm, which defaults to port 80. - a better approach is to have both projects using the same
defaults, but for now we'll include both urls instead. - the ksm decrypt requests happen asynchronously, so there should not be any performance degradation. (since either one of the urls will timeout)
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Drop some comments. - not really helpful, better to just depend on what the code does.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid variable aliases.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor. - simplify and avoid using different arrays with same values. - build $otpParams from $otpinfo as soon as we have ksm result, then unset $otpinfo. - futher down, only use $otpParams and $localParams.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor and modify LOG_INFO message. - as a result of this commit, key=val are separated with two spaces instead of one.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid variable aliases.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid variable aliases.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid variable aliases.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid variable aliases.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid variable aliases.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid variable aliases.
2015-09-15 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Avoid variable aliases.
2015-09-14 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: Bump versions.
2015-09-14 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: NEWS for 2.32
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-sync.php: Refactor.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-sync.php, ykval-verify.php: Modified log messages. - avoid doing what is already handled by the Log class. - the log name is appended automatically, so don't append it again in the invocation. i.e. "ykval-verify" - the log level name is also appended automatically, so don't append it manually, especially when it doesn't match the
log priority! i.e. LOG_WARNING -> ":notice:" - fix whitespace in some messages.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Cosmetic.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Refactor.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Refactor.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Rename variable.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Rename variable.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Refactor. - make it easier to follow, create prefix first, then suffix.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Refactor. - build separate string from $extra array, and append it in syslog call.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Rename variable.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Refactor.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-log.php: Refactor. - init variables as class property, no need to init in construct. - set scopes on private properties, and public methods.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Refactor. - get rid of log_format() function. - was only used in one place and it just complicates things.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Documentation.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Cosmetic.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Refactor. - $urls is already checked prior to invoking function.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: Bump versions.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: Cosmetic fix.
2015-09-10 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: NEWS for 2.31
2015-09-09 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-sync.php: Fix bug. - fix fatal error when an empty sync request is sent to the server. - logging boilerplate must be initiated before we start validating
the request.
2015-09-09 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Fix bug. - argument to sprintf, not concat to first argument!
2015-09-09 Jean Paul Galea <jeanpaul@yubico.com>
* Makefile, NEWS: Bump versions.
2015-09-09 Jean Paul Galea <jeanpaul@yubico.com>
* NEWS: NEWS for 2.30
2015-09-09 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-vallatency.php: Fix. - add newline for munin error message.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-queuelength.php, ykval-synclib.php: Refactor out
function into library.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-queuelength.php: Rewrote ykval-munin-queuelength
plugin. - bring in line with ksm and val latency plugin.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php: Rewrite ykval-munin-ksmlatency plugin. - same as 1e4da5dac66210a85cf0e3bee739a6839edeeb46, but for ksm latency plugin.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php, ykval-munin-vallatency.php: Rewrite
ykval-munin-vallatency plugin. - avoid having to use the same internal and label name, as it's problematic. - internal name has a lot of restrictions: s/^[^A-Za-z_]/_/ s/[^A-Za-z0-9_]/_/g - which doesn't allow us to show proper label names, the names that users will see. - label displays :80 or :443 depending on scheme. - avoid ugliness with shortname() and instead use endpoints().
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-queuelength.php: Cosmetic.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Use underscore instead of colon for host/port. - munin plugin only supports a-zA-Z0-9_ so colon will probably give
us problems.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-queuelength.php: Fix. - import common, required for shortname function.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php, ykval-munin-queuelength.php,
ykval-munin-vallatency.php: Add shortname failure checks for munin
plugins.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php, ykval-munin-ksmlatency.php,
ykval-munin-queuelength.php, ykval-munin-vallatency.php: Rename
function
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-queuelength.php: Modify ykval-munin-queuelength
plugin. - use host (and port if any) for graph title.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php, ykval-munin-vallatency.php: Use single
quotes where possible.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php, ykval-munin-vallatency.php: Use echo
in all munin php plugins.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-queuelength.php: Modify ykval-munin-queuelength
plugin. - don't auto configure if running a single node cluster. (i.e. no queues for sync requests to other servers).
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-queuelength.php: Refactor. - move autoconf block lower down. - will be taken advantage of in a newer commit.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php: Modify ykval-munin-ksmlatency. - same as f2604e751abe43c2cec773194172ac90b9f89a98, except this is for KSM URLs.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php: Add FIXME marker.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-vallatency.php: Modify ykval-munin-vallatency plugin. - don't auto configure if running a single node cluster. (i.e. no other servers to sync to).
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php, ykval-munin-vallatency.php: Modify
ykval-munin-vallatency plugin. - use hostname (+ port if any) for graph name. i.e. if we have a sync URL: https://api.yubico.com:8080/wsapi/2.0/sync instead of having "api" as name, we have "api.yubico.com:8080". - also avoid using regex and use parse_url() from php core instead.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php: Rename variable. - $ksms => $urls - $ksm => $url - mainly to be closer to vallatency plugin.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-vallatency.php: Cosmetic.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php: Rename variable.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php, ykval-munin-vallatency.php: Use
bracket guards for substitution.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php, ykval-munin-vallatency.php: Drop half baked
functionality in ykval-munin-vallatency. - plugin assumed URL uses a hostname (no static ips) and that hostname resolves to both ipv4 and ipv6. - if we want to differentiate stats between ipv4 and ipv6, we need to re-think this and do it in a smart way. - for now we prefer to allow cURL to pick whatever IP it resolves, and run the latency test on that. - signed off by Klas Lindfors.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-checksum-clients, ykval-checksum-deactivated, ykval-export,
ykval-export-clients, ykval-gen-clients, ykval-import,
ykval-import-clients, ykval-munin-ksmlatency.php,
ykval-munin-queuelength.php, ykval-munin-vallatency.php,
ykval-munin-yubikeystats.php, ykval-nagios-queuelength.php,
ykval-queue: Refactor include paths. - use PATH_SEPARATOR everywhere, instead of a mix of PATH_SEPARATOR and hard coded colons. - always include /usr/share/yubikey-val first, then /etc/yubico/val. - should not have any visible affects, since no file names are common between the two directories. - use array+implode to make it easier to add/remove paths, and to avoid hardcoded the path separator.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-yubikeystats.php: Refactor. - string substitution rather than concatenation.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php: Refactor ykval-munin-ksmlatency
plugin. - depend on libcurl instead of curl binary. - due to this commit, requests sent to KSM URLs will contain a User-Agent header.
2015-09-08 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php, ykval-munin-vallatency.php: Move function into
ykval-common.php
2015-09-07 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-vallatency.php: Refactor. - don't depend on external binaries, it assumes too much and is dangerous. - we can depend on libcurl instead, since it's already a dependency in core. - we should do this for other plugins too, and move the new function into ykval-common.php - plugin reports same exact values as before.
2015-09-07 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-munin-ksmlatency.php, ykval-munin-queuelength.php,
ykval-munin-vallatency.php, ykval-munin-yubikeystats.php: Cosmetic
changes. - refactor whitespace for munin plugins written in php. - change spaces into tabs and fix brackets mostly.
2015-08-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-queue: Modify ykval-queue daemon. - don't run ykval-queue for single node configurations.
2015-08-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-db-pdo.php: Refactor. - remove unnecessary else {} wrapper.
2015-08-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-db-pdo.php: Cosmetic changes. - make it easier to understand query construction.
2015-08-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Don't set a default value for reSync argument. - reSync() is only called in ykval-queue, and that sets an $older_than argument. - additionally, the defaults did not match. - the value in ykval-queue (via ykval-config) is 10 seconds, and the value in reSync($older_than=) was 60 seconds. - no functional change, just makes things less confusing.
2015-08-12 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: FIXME marker.
2015-08-12 Jean Paul Galea <jeanpaul@yubico.com>
* travis/server.pl: Fix failing tests. - bug introduced in 382cfc2ab506a4c0f6ba0222d473ff3df77dd6f5. - travis perl server test should use port 8002 to simulate ksm
server.
2015-07-28 Jean Paul Galea <jp@galea.se>
* ykval-queue: FIXME markers.
2015-07-28 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Modify default KSM URL. - our ksm daemon listens on port 8002 by default, so ykval should also have the same default.
2015-07-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Fix. - fix bug introduced in 6181abee14aacca55e81f8d051b2ed0d2002eefa. - essentially, strftime() uses different format than date()
2015-07-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor. - avoid unnecessary strtotime() call. - instead of: strtotime(date('Y-m-d H:i:s', $timestamp)) use: $timestamp since: $timestamp === strtotime(date('Y-m-d H:i:s', $timestamp))
2015-07-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor. - strftime -> date. - strftime is same as date, but with locales. - date format doesn't output names (January, March, etc.), so locale doesn't matter. - also, would we really want locale in logs?
2015-07-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Modify log write. - Log::log() internally support array implode, so no need to duplicate functionality. - however, the internal implode uses two consecutive spaces as
separator, so this will change the log format slightly. e.g. "delta=x now=y" becomes "delta=x now=y"
2015-07-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor.
2015-07-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Cosmetic changes.
2015-07-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor.
2015-07-24 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor.
2015-07-22 Jean Paul Galea <jp@galea.se>
* ykval-common.php: Refactor. - rename $curlopts -> $opts.
2015-07-22 Jean Paul Galea <jp@galea.se>
* ykval-common.php: Refactor.
2015-07-22 Jean Paul Galea <jp@galea.se>
* ykval-common.php: Refactor. - rename $handle -> $ch.
2015-07-22 Jean Paul Galea <jp@galea.se>
* ykval-common.php: Refactor.
2015-07-22 Jean Paul Galea <jp@galea.se>
* ykval-common.php: Cosmetic changes.
2015-07-22 Jean Paul Galea <jp@galea.se>
* ykval-common.php: Cosmetic changes.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: FIXME markers.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Cosmetic changes.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-common.php: Refactor.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Better grouping. - same as 1e799aa6e57dffcb7baeb130919180bef22ea085. - group $timeout filtering and validation. - this commit might change replies sent to clients, since the validation check is done eaerlier now, and we might return S_MISSING_PARAM before S_BAD_OTP for example. - this should really not cause any issues though, the order of which error is raised first should not matter to
clients.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Better grouping. - group $sl filtering and validation. - this commit might change replies sent to clients, since the validation check is done eaerlier now, and we might return S_MISSING_PARAM before S_BAD_OTP for example. - this should really not cause any issues though, the order of which error is raised first should not matter to
clients.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor and unset after use.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor. - single quotes. - unset after use. - don't wrap.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Cosmetic changes.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor. - only add nonce to $extra array after check.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor. - $new_otp not used afterwards, clean up to avoid reuse by mistake.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Better grouping. - no functional affect whatsoever.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: More robust https check.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor. - avoid using $_SERVER vars in "core", helps when debugging or running via cli.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-common.php: Refactor sign function. - this commit might affect LOG_DEBUG message, since now we log utf8_encode($qs) not $qs. - this is probably what we want though, since we run hash_hmac on the latter.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Unwrap else block. - sendResp calls exit()
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: More minor fixes.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor. - $apiKey is initiliased further down.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: Refactor. - str substitution rather than concat. - cosmetic changes.
2015-07-21 Jean Paul Galea <jp@galea.se>
* ykval-verify.php: double -> single quotes.
2015-07-20 Jean Paul Galea <jp@galea.se>
* COPYING, Makefile, ykval-checksum-clients,
ykval-checksum-clients.1, ykval-checksum-deactivated,
ykval-checksum-deactivated.1, ykval-common.php, ykval-config.php,
ykval-db-oci.php, ykval-db-pdo.php, ykval-db.php, ykval-export,
ykval-export-clients, ykval-export-clients.1, ykval-export.1,
ykval-gen-clients.1, ykval-import, ykval-import-clients,
ykval-import-clients.1, ykval-import.1, ykval-log.php,
ykval-munin-ksmlatency.php, ykval-munin-ksmresponses.pl,
ykval-munin-queuelength.php, ykval-munin-responses.pl,
ykval-munin-vallatency.php, ykval-munin-yubikeystats.php,
ykval-nagios-queuelength.php, ykval-ping.php, ykval-queue,
ykval-queue.1, ykval-resync.php, ykval-revoke.php, ykval-sync.php,
ykval-synchronize, ykval-synchronize.1, ykval-synclib.php,
ykval-verify.php: Update copyright year.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Add FIXME markers.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-synclib.php: Refactor. - negate test and return early. - avoid wrapping whole function in `if () { }`. - move $condition below $arr, since $arr is passwed first, then $condition, to
conditionalUpdateBy().
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-synclib.php: Refactor.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Improve documentation.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Refactor database configuration. - don't repeat config-db.php file path - add @is_readable, we might not have the proper permissions. - use 'require_once' instead of 'include', this file should only be included once and we should fail dramatically if we can't load it. - better documentation.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Cosmetic changes. \# -> //
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Cosmetic changes.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Move comment where applicable.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Cosmetic changes.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Remove unused variables. - will add db host/port later, currently they are ignored even if
configured.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-checksum-clients.1, ykval-checksum-deactivated.1,
ykval-export-clients.1, ykval-export.1, ykval-gen-clients.1,
ykval-import-clients.1, ykval-import.1, ykval-nagios-queuelength.1,
ykval-queue.1, ykval-synchronize.1: Use TLS for man page
www.yubico.com links.
2015-07-20 Jean Paul Galea <jp@galea.se>
* ykval-config.php: Use TLS in ykval-config.php examples
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Refactor counter logic. - break up into multiple if comparisons.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-ping.php: Single quotes.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Added helper comments.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes. - method grouping.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Change scope on private methods. - mainly to help refactor, and avoid grep'ing globally.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor. - getClientData() returns array or bool false on failure.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Set scopes on methods. - confirmed to be used publically.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: FIXME markers.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Fix. - fix bug introduced in a28ad6df698b4ef20b6698a1f993019ad25bef25.
2015-07-18 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Refactor. - use single quotes where possible.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: FIXME marker. - probably should be '&local_counter' not ',local_counter'. - check later as this is written to db and if we fix here, we might break other stuff.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Fix bug. - this was not introduced by my refactoring. - LOG_ALERT message was incorrect, probably yy,p from counter block.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Fix bug. - this was not introduced by my refactoring. - LOG_ALERT for; yk_low, yk_high, nonce was written only if yk_use failed to be parsed. - as a result, this commit might change LOG_ALERT output.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Refactor away useless else { } wrap.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Refactor away useless variable.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Refactor. - be explicit and declare as public, since we're clearly using it.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-resync.php, ykval-sync.php, ykval-verify.php: Refactor. - getLocalParams() returns array or bool false on failure.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor. - str sub instead of concat.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor. - removed duplicate variable.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Refactor. - remove unnecessary else { } wrap.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Refactor. - str sub instead of concat
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Refactor. - KSMDecryptOTP returns array or bool false on failure.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Refactor. - minor improvements. - move $ret init right before it's used. - use string substitution rather than concatenation.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes. - adhere with some form of convetion for comments. - use single quotes where possible.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php, ykval-synclib.php: Refactor. - retrieveURLasync() always returns FALSE on failure now, before it might have returned a string. - use array_shift($a) to pop first element, safer than $a[0]; - this commit might affect what is written to LOG_DEBUG, since now we only write the YK-KSM message when we are certain to have a valid response.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-synclib.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Refactor. - remove counter and use count($array) instead.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Refactor. - $id never used.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Refactor. - use string substitution rather than concatenation.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Refactor. - $mrc never used.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Refactor. - enable strict comparison for sscanf result. - use single quotes where possible. - styling.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-common.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>
* ykval-verify.php: Cosmetic changes.
2015-07-17 Jean Paul Galea <jeanpaul@yubico.com>