From 8fdead2ac76a6402f0bcdcd5151b98bbc9163334 Mon Sep 17 00:00:00 2001 From: codehippie1 Date: Thu, 30 May 2024 19:54:36 -0400 Subject: [PATCH] Initial thoughts on 4.x upgrade --- lib/Pdfjs.4.x.upgrade.MD | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 lib/Pdfjs.4.x.upgrade.MD diff --git a/lib/Pdfjs.4.x.upgrade.MD b/lib/Pdfjs.4.x.upgrade.MD new file mode 100644 index 00000000..de4ebc63 --- /dev/null +++ b/lib/Pdfjs.4.x.upgrade.MD @@ -0,0 +1,14 @@ +Let's leave sample app for now. It is easy to rewrite from scratch. +Let's leave live demo as well. Plan is to rewrite. + +- Why was ng-packagr added as dev dependency ? +- Assuming shx works on windows as well. New to this. +- PDF's are loaded inside an iframe. Does document.addEventListner() gets fired even if we use iframe? +There are two scenarios. PDF can be embedded in html or opened in a new window. +- I like the way pdfjs's event bus is used. In the beginning I had to hack pdfjs library pdfjs library to send those browser events. :-) + + + +Thought for community - How about starting a discord server for ng2-pdfjs-viewer ? + +