Skip to content

Update MWV - this is the smalles version with which I could compile. #2

Update MWV - this is the smalles version with which I could compile.

Update MWV - this is the smalles version with which I could compile. #2

GitHub Actions / Clippy (beta) succeeded Oct 10, 2024 in 1s

Clippy (beta)

88 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 88
Note 0
Help 0

Versions

  • rustc 1.80.0 (051478957 2024-07-21)
  • cargo 1.80.0 (376290515 2024-07-16)
  • clippy 0.1.80 (0514789 2024-07-21)

Annotations

Check warning on line 933 in halo2_frontend/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_frontend/src/dev.rs:928:41
    |
928 | / ...                   &util::load_instance(
929 | | ...                       n,
930 | | ...                       row,
931 | | ...                       &self.cs.instance_queries,
932 | | ...                       &self.instance,
933 | | ...                   ),
    | |_______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
    |
928 ~                                         util::load_instance(
929 +                                             n,
930 +                                             row,
931 +                                             &self.cs.instance_queries,
932 +                                             &self.instance,
933 ~                                         ),
    |

Check warning on line 927 in halo2_frontend/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_frontend/src/dev.rs:927:41
    |
927 | ...                   &util::load(n, row, &self.cs.advice_queries, &self.advice),
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, &self.advice)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 926 in halo2_frontend/src/dev.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_frontend/src/dev.rs:926:41
    |
926 | ...                   &util::load(n, row, &self.cs.fixed_queries, &self.fixed),
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

Check warning on line 66 in halo2_frontend/src/dev/util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

manual implementation of `split_once`

warning: manual implementation of `split_once`
  --> halo2_frontend/src/dev/util.rs:66:17
   |
66 |         let s = s.splitn(2, "0x").nth(1).unwrap().splitn(2, ")").nth(0).unwrap();
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.split_once("0x").unwrap().1`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once
   = note: `-W clippy::manual-split-once` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::manual_split_once)]`

Check warning on line 66 in halo2_frontend/src/dev/util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unnecessary use of `splitn`

warning: unnecessary use of `splitn`
  --> halo2_frontend/src/dev/util.rs:66:17
   |
66 |         let s = s.splitn(2, "0x").nth(1).unwrap().splitn(2, ")").nth(0).unwrap();
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.splitn(2, "0x").nth(1).unwrap().split(")")`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn
   = note: `-W clippy::needless-splitn` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::needless_splitn)]`

Check warning on line 66 in halo2_frontend/src/dev/util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent

warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
  --> halo2_frontend/src/dev/util.rs:66:17
   |
66 |         let s = s.splitn(2, "0x").nth(1).unwrap().splitn(2, ")").nth(0).unwrap();
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `s.splitn(2, "0x").nth(1).unwrap().splitn(2, ")").next()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
   = note: `-W clippy::iter-nth-zero` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::iter_nth_zero)]`

Check warning on line 333 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:333:9
    |
333 |     /// does not perform any checks
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
333 |     ///   does not perform any checks
    |         ++

Check warning on line 331 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:331:9
    |
331 |     /// Checks that field elements are less than modulus, and then checks that the point is on the curve.
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
331 |     ///   Checks that field elements are less than modulus, and then checks that the point is on the curve.
    |         ++

Check warning on line 329 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:329:9
    |
329 |     /// `PrimeField` implementation, and checks that the element is less than the modulus.
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
329 |     ///   `PrimeField` implementation, and checks that the element is less than the modulus.
    |         ++

Check warning on line 328 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:328:9
    |
328 |     /// Reads a field element in standard form, with endianness specified by the
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
328 |     ///   Reads a field element in standard form, with endianness specified by the
    |         ++

Check warning on line 310 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:310:9
    |
310 |     /// Does so by first writing the verifying key and then serializing the rest of the data (in the form of field polynomials)
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
310 |     ///   Does so by first writing the verifying key and then serializing the rest of the data (in the form of field polynomials)
    |         ++

Check warning on line 309 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:309:9
    |
309 |     /// WITHOUT performing the expensive Montgomery reduction.
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
309 |     ///   WITHOUT performing the expensive Montgomery reduction.
    |         ++

Check warning on line 308 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:308:9
    |
308 |     /// Writes a field element into raw bytes in its internal Montgomery representation,
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
308 |     ///   Writes a field element into raw bytes in its internal Montgomery representation,
    |         ++

Check warning on line 306 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:306:9
    |
306 |     /// `PrimeField` implementation.
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
306 |     ///   `PrimeField` implementation.
    |         ++

Check warning on line 305 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
   --> halo2_backend/src/plonk.rs:305:9
    |
305 |     /// Writes a field element in standard form, with endianness specified by the
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
305 |     ///   Writes a field element in standard form, with endianness specified by the
    |         ++

Check warning on line 98 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
  --> halo2_backend/src/plonk.rs:98:9
   |
98 |     /// does not perform any checks
   |         ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
98 |     ///   does not perform any checks
   |         ++

Check warning on line 96 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
  --> halo2_backend/src/plonk.rs:96:9
   |
96 |     /// Checks that field elements are less than modulus, and then checks that the point is on the curve.
   |         ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
96 |     ///   Checks that field elements are less than modulus, and then checks that the point is on the curve.
   |         ++

Check warning on line 94 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
  --> halo2_backend/src/plonk.rs:94:9
   |
94 |     /// `PrimeField` implementation, and checks that the element is less than the modulus.
   |         ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
94 |     ///   `PrimeField` implementation, and checks that the element is less than the modulus.
   |         ++

Check warning on line 93 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
  --> halo2_backend/src/plonk.rs:93:9
   |
93 |     /// Reads a field element in standard form, with endianness specified by the
   |         ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
93 |     ///   Reads a field element in standard form, with endianness specified by the
   |         ++

Check warning on line 72 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
  --> halo2_backend/src/plonk.rs:72:9
   |
72 |     /// WITHOUT performing the expensive Montgomery reduction.
   |         ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
72 |     ///   WITHOUT performing the expensive Montgomery reduction.
   |         ++

Check warning on line 71 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
  --> halo2_backend/src/plonk.rs:71:9
   |
71 |     /// Writes a field element into raw bytes in its internal Montgomery representation,
   |         ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
71 |     ///   Writes a field element into raw bytes in its internal Montgomery representation,
   |         ++

Check warning on line 69 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
  --> halo2_backend/src/plonk.rs:69:9
   |
69 |     /// `PrimeField` implementation.
   |         ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
69 |     ///   `PrimeField` implementation.
   |         ++

Check warning on line 68 in halo2_backend/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

doc list item missing indentation

warning: doc list item missing indentation
  --> halo2_backend/src/plonk.rs:68:9
   |
68 |     /// Writes a field element in standard form, with endianness specified by the
   |         ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
   |
68 |     ///   Writes a field element in standard form, with endianness specified by the
   |         ++

Check warning on line 426 in halo2_backend/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_backend/src/plonk/prover.rs:426:54
    |
426 |                         Blind(Scheme::Scalar::random(&mut rng))
    |                                                      ^^^^^^^^ help: change this to: `rng`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 409 in halo2_backend/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_backend/src/plonk/prover.rs:409:56
    |
409 |                         *cell = Scheme::Scalar::random(&mut rng);
    |                                                        ^^^^^^^^ help: change this to: `rng`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`