-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pre-built binaries via BinaryBuilder #24
Conversation
Minimum Julia version to 1.3
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 95.32% 97.84% +2.52%
==========================================
Files 1 1
Lines 107 93 -14
==========================================
- Hits 102 91 -11
+ Misses 5 2 -3
Continue to review full report at Codecov.
|
Thank you! I will try it later. One thing to notice is that the original source code was slightly modified to take care of the verbosity. Need to check if the verbose option is working |
I've removed the custom print function in For the record, the build script is here: https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/liblinear/build_tarballs.jl |
I'll diff it later today. The change was designed for julia if I remember correctly. |
Bump |
@cossio checking the changes now. It was a busy working Friday |
Signed-off-by: lizz <363664470@qq.com>
Great, thanks! |
Thanks! |
This makes the installation of this package much more robust, on multiple platforms.
cc: @innerlee