Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-built binaries via BinaryBuilder #24

Merged
merged 4 commits into from
Jun 6, 2020
Merged

Use pre-built binaries via BinaryBuilder #24

merged 4 commits into from
Jun 6, 2020

Conversation

aviks
Copy link
Contributor

@aviks aviks commented Jun 2, 2020

This makes the installation of this package much more robust, on multiple platforms.

cc: @innerlee

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #24 into master will increase coverage by 2.52%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   95.32%   97.84%   +2.52%     
==========================================
  Files           1        1              
  Lines         107       93      -14     
==========================================
- Hits          102       91      -11     
+ Misses          5        2       -3     
Impacted Files Coverage Δ
src/LIBLINEAR.jl 97.84% <88.88%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6f441...f06f0be. Read the comment docs.

@innerlee
Copy link
Collaborator

innerlee commented Jun 3, 2020

Thank you! I will try it later. One thing to notice is that the original source code was slightly modified to take care of the verbosity. Need to check if the verbose option is working

@aviks
Copy link
Contributor Author

aviks commented Jun 3, 2020

original source code was slightly modified to take care of the verbosity

I've removed the custom print function in libzz , and replaced it with a @cfunction call in Julia. So that part is OK. But if there were changes to the liblinear C code, then if you can point me to the changes, I'll try and incorporate that.

For the record, the build script is here: https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/liblinear/build_tarballs.jl

@innerlee
Copy link
Collaborator

innerlee commented Jun 4, 2020

I'll diff it later today. The change was designed for julia if I remember correctly.

@cossio
Copy link

cossio commented Jun 5, 2020

Bump

@innerlee
Copy link
Collaborator

innerlee commented Jun 6, 2020

@cossio checking the changes now. It was a busy working Friday

Signed-off-by: lizz <363664470@qq.com>
@innerlee innerlee merged commit 3a51a16 into JuliaML:master Jun 6, 2020
@innerlee
Copy link
Collaborator

innerlee commented Jun 6, 2020

Great, thanks!

@cossio
Copy link

cossio commented Jun 6, 2020

Thanks!

@aviks aviks deleted the as/bb branch June 6, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants