Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DSLR pictures for metadata tests #4

Open
fwsmit opened this issue Jun 11, 2024 · 8 comments
Open

Add DSLR pictures for metadata tests #4

fwsmit opened this issue Jun 11, 2024 · 8 comments

Comments

@fwsmit
Copy link

fwsmit commented Jun 11, 2024

I'm making this issue to inform if DSLR pictures are desired to test if the metadata is correctly extracted. I'm interested in this, because currently the timezone information is not correctly extracted for my camera (Sony A7 first gen). Since I can set a timezone in the camera settings, I believe this information is stored somewhere in the metadata and it should be able to be extracted.

In discord the following was mentioned by user "etnoy" leading me to this repository:

Since the topic of timezones is a literal minefield the best way to start working on this is to have a bunch of assets to test with that exhibit a problem in the current setup. In the best case, maybe you have some photos you could donate to the public domain so that we can add them to our test assets. I will scale them down as we're really only interested in the metadata. They will then be added to this repository: https://github.com/immich-app/test-assets after which you can start making assertions in the form of e2e tests

@bo0tzz
Copy link
Member

bo0tzz commented Jun 11, 2024

cc @etnoy

@etnoy
Copy link
Contributor

etnoy commented Jun 12, 2024

Yes, if you have specific cameras with odd metadata, please add samples here and write tests. Make sure you publish your assets in the public domain

@fwsmit
Copy link
Author

fwsmit commented Jun 12, 2024

I will write a fix for it in exiftools-vendored, where I'll also add tests with example images. Is it still necessary to add tests here?

Ref: photostructure/exiftool-vendored.js#187

@etnoy
Copy link
Contributor

etnoy commented Jun 12, 2024

Why not? I'd like to have a wide variety of test assets in here so we can ensure problematic cases are handled well

@fwsmit
Copy link
Author

fwsmit commented Jun 12, 2024

Specifically the timezone metadata that I'm interested in should be handled by exiftools-vendored afaik. But of course it could still be useful to check other things here. I can of course provide the images. Not sure if I would want to write tests for it

@etnoy
Copy link
Contributor

etnoy commented Jun 12, 2024

Ideally I'd like a few samples from most major DSLR cameras. As a Nikon user I've uploaded some raw files from my cameras. Feel free to upload some a7 samples.

@fwsmit
Copy link
Author

fwsmit commented Jun 12, 2024

I did some digging and I found an online repository of many raw images of different camera models. This repository is available under the creative commons license and can be found on https://rawsamples.ch/. I would suggest using this.

@etnoy
Copy link
Contributor

etnoy commented Aug 27, 2024

I did some digging and I found an online repository of many raw images of different camera models. This repository is available under the creative commons license and can be found on https://rawsamples.ch/. I would suggest using this.

That is a great repository, however the reason for having our own repo is that we use it in automatic testing. It appears that rawsamples is in the public domain, so if we find odd quirks we don't handle correctly I suggest copying in those specific cases into our repo. We can't just take in everything since git doesn't like lots of raw photos, we need to be smart in what we include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants