Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assign separate phases to load components #149

Merged

Conversation

sasanjac
Copy link
Member

Fixes #86

@SebastianDD
Copy link
Member

1Ph producer not considered yet as power is always intended to be symmetrical. power is calculated before connectedPhases is created. --> cfg. create_producer()

also for load:
In calc_load_{..}_power () it is only checked for ci_sym and not for ConnectedPhases.
imagine a Load of ConnectionType 1PH PH-E, which indeed returns ci_sym=symmetrical
--> additional problem here: as PF handle e.g. 1PH PH-E loads as symmetrical, the variables plini_{r,s,t} are not accessible, so function calc_normal_load_power_asym() can not be used.

@SebastianDD
Copy link
Member

SebastianDD commented Jul 3, 2023

resolve first: psdm issue

@sasanjac sasanjac force-pushed the sasanjac/86-feat-adapt-s_rst-to-phase-connection-type-of-loads branch from 568b4db to a78053b Compare July 4, 2023 12:16
@SebastianDD
Copy link
Member

SebastianDD commented Jul 5, 2023

TODO:

  • adapt last code line in exporter example to be in line with pydantic v2
  • need to target at upcoming psdm 1.4.1 incl pydantic v2

@SebastianDD SebastianDD added this to the 1.6.0 milestone Jul 6, 2023
SebastianDD
SebastianDD previously approved these changes Jul 6, 2023
Copy link
Member Author

@sasanjac sasanjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's look at the comments first before merging

powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
powerfactory_tools/exporter/exporter.py Outdated Show resolved Hide resolved
@SebastianDD SebastianDD linked an issue Jul 7, 2023 that may be closed by this pull request
@sasanjac sasanjac linked an issue Jul 25, 2023 that may be closed by this pull request
SebastianDD
SebastianDD previously approved these changes Jul 25, 2023
Copy link
Member

@SebastianDD SebastianDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fails because of pydantic bug

SebastianDD
SebastianDD previously approved these changes Jul 26, 2023
@sasanjac sasanjac merged commit 449f8ac into main Jul 26, 2023
2 checks passed
@sasanjac sasanjac deleted the sasanjac/86-feat-adapt-s_rst-to-phase-connection-type-of-loads branch July 26, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants