From b8362669f0cdc16d72dc0be8b622a5a2e47638b9 Mon Sep 17 00:00:00 2001 From: Sasan Jacob Rasti Date: Wed, 26 Jul 2023 13:01:46 +0200 Subject: [PATCH 1/3] fix: zero sequence magnetisation information Fixes #38 --- psdm/topology/transformer.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/psdm/topology/transformer.py b/psdm/topology/transformer.py index be02706..0d663ab 100644 --- a/psdm/topology/transformer.py +++ b/psdm/topology/transformer.py @@ -70,6 +70,11 @@ class Transformer(Base): vector_group: VectorGroup # specifier for connection of wiring e.g. DYn5 i_0: float # no-load current in % p_fe: float # no-load losses (Iron losses) + z_0: float # zero sequence values of PI-representation + r_0: float # zero sequence values of PI-representation + x_0: float # zero sequence values of PI-representation + i_00: float # zero sequence values of PI-representation + p_fe0: float # zero sequence values of PI-representation windings: list[Winding] # winding object for each voltage level phase_technology_type: TransformerPhaseTechnologyType | None = None # three- or single-phase-transformer description: str | None = None From ff4faa3664ecd97dec143467680e0f9157d59dbf Mon Sep 17 00:00:00 2001 From: Sasan Jacob Rasti Date: Fri, 4 Aug 2023 10:46:57 +0200 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: FiedLa <122098671+FiedLa@users.noreply.github.com> --- psdm/topology/transformer.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/psdm/topology/transformer.py b/psdm/topology/transformer.py index 0d663ab..c1d5f5a 100644 --- a/psdm/topology/transformer.py +++ b/psdm/topology/transformer.py @@ -70,9 +70,6 @@ class Transformer(Base): vector_group: VectorGroup # specifier for connection of wiring e.g. DYn5 i_0: float # no-load current in % p_fe: float # no-load losses (Iron losses) - z_0: float # zero sequence values of PI-representation - r_0: float # zero sequence values of PI-representation - x_0: float # zero sequence values of PI-representation i_00: float # zero sequence values of PI-representation p_fe0: float # zero sequence values of PI-representation windings: list[Winding] # winding object for each voltage level From 4681bb64974b7896e1c5f37c21a9fb753418f2e3 Mon Sep 17 00:00:00 2001 From: Sasan Jacob Rasti Date: Fri, 4 Aug 2023 10:50:04 +0200 Subject: [PATCH 3/3] update ci --- .github/workflows/checks.yml | 4 ++-- .github/workflows/release.yml | 4 ++-- .github/workflows/tests.yml | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 905755c..3121229 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -17,8 +17,8 @@ jobs: with: fetch-depth: 1 - - name: Setting up PDM - uses: pdm-project/setup-pdm@v3.2 + - name: Setting up PDM @ ${{ matrix.python-version }} + uses: pdm-project/setup-pdm@v3.3 with: python-version: ${{ matrix.python-version }} cache: true diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d8e4c41..bd3093f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -56,8 +56,8 @@ jobs: token: ${{ secrets.ACCESS_TOKEN }} fetch-depth: 0 - - name: Set up PDM - uses: pdm-project/setup-pdm@v3.2 + - name: Set up PDM @ ${{ matrix.python-version }} + uses: pdm-project/setup-pdm@v3.3 with: python-version: ${{ env.PYTHON_VERSION }} cache: true diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 8b85dd9..bc9c517 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -27,7 +27,7 @@ jobs: fetch-depth: 1 - name: Set up PDM @ ${{ matrix.python-version }} - uses: pdm-project/setup-pdm@v3.2 + uses: pdm-project/setup-pdm@v3.3 with: python-version: ${{ matrix.python-version }} cache: true