Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate to pydantic v2.0 #36

Merged
merged 12 commits into from
Jul 6, 2023
Merged

fix: migrate to pydantic v2.0 #36

merged 12 commits into from
Jul 6, 2023

Conversation

sasanjac
Copy link
Member

@sasanjac sasanjac commented Jul 4, 2023

Fixes #33

@sasanjac sasanjac self-assigned this Jul 4, 2023
@sasanjac sasanjac requested a review from SebastianDD July 4, 2023 13:27
@SebastianDD
Copy link
Member

SebastianDD commented Jul 4, 2023 •
edited
Loading

@sasanjac : unfortunately we now get error when importing SteadyStateCase
"PydanticUserError: unique_items is removed, use Set instead(this feature is discussed in pydantic/pydantic-core#296)"
I remeber that we were forcing this issue some time ago

its about conlist(class, unique_items=True) vs set
may replace with conset

@SebastianDD SebastianDD removed their request for review July 4, 2023 14:21
@SebastianDD SebastianDD self-requested a review July 5, 2023 15:31
@sasanjac sasanjac merged commit 7df9413 into main Jul 6, 2023
4 checks passed
@sasanjac sasanjac deleted the sasanjac/33-fix-migrate-to-pydantic-v20 branch July 6, 2023 07:07
@SebastianDD SebastianDD mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianDD SebastianDD SebastianDD approved these changes

Assignees

@sasanjac sasanjac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: migrate to pydantic v2.0
2 participants
@sasanjac @SebastianDD