From f705d0761cce699fb14600a0bdbd2333353f04c1 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Wed, 8 Nov 2023 17:00:56 +0100 Subject: [PATCH 1/3] Remove legacy todo Don't think this extraction is worth the hassle --- .github/workflows/deploy-documentation-preview.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/deploy-documentation-preview.yml b/.github/workflows/deploy-documentation-preview.yml index 27db1b4cdb5..97566040352 100644 --- a/.github/workflows/deploy-documentation-preview.yml +++ b/.github/workflows/deploy-documentation-preview.yml @@ -56,7 +56,6 @@ jobs: run: rm resources/views/vendor/hyde/components/docs/documentation-article.blade.php - name: Create component to add an information badge - # TODO 1. Extract to component. 2. Add feature to hide card which is stored in local session storage for the duration of the visit (so it's reset on next PR page visit) run: | mkdir -p resources/views/vendor/hyde/layouts cp vendor/hyde/framework/resources/views/layouts/docs.blade.php resources/views/vendor/hyde/layouts/docs.blade.php From 580e14674f8deaba4d2dedba879c14e9f527236b Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Wed, 8 Nov 2023 17:03:09 +0100 Subject: [PATCH 2/3] Unwrap todo markers to general comments --- .../publications/src/Commands/Helpers/InputStreamHandler.php | 2 +- packages/publications/src/Commands/MakePublicationCommand.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/publications/src/Commands/Helpers/InputStreamHandler.php b/packages/publications/src/Commands/Helpers/InputStreamHandler.php index cbb3a369bb5..001e85ff135 100644 --- a/packages/publications/src/Commands/Helpers/InputStreamHandler.php +++ b/packages/publications/src/Commands/Helpers/InputStreamHandler.php @@ -53,7 +53,7 @@ protected function getLinesFromInputStream(): array protected function shouldTerminate(string $line): bool { - // TODO add option to terminate with two blank lines (useful for tags input, but is default to false, for example to accept paragraphs) + // We could add an option to terminate with two blank lines (useful for tags input, but is default to false, for example to accept paragraphs) return $line === self::TERMINATION_SEQUENCE || str_contains($line, self::END_OF_TRANSMISSION); } diff --git a/packages/publications/src/Commands/MakePublicationCommand.php b/packages/publications/src/Commands/MakePublicationCommand.php index 38cda7d6e37..a7d5750d477 100644 --- a/packages/publications/src/Commands/MakePublicationCommand.php +++ b/packages/publications/src/Commands/MakePublicationCommand.php @@ -171,7 +171,7 @@ protected function handleEmptyMediaFilesCollection(PublicationFieldDefinition $f $this->newLine(); $this->warn("Warning: No media files found in $directory"); if ($this->confirm('Would you like to skip this field?', true)) { - // TODO We could have a choice here, where 0 skips, and 1 reloads the media files + // We could have a choice here, where 0 skips, and 1 reloads the media files return null; } else { throw new InvalidArgumentException('Unable to locate any media files for this publication type'); From 42993cda2911d78d93892ccafa7ae82765383ccc Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Wed, 8 Nov 2023 17:03:40 +0100 Subject: [PATCH 3/3] Convert todo to deprecation --- packages/publications/src/Concerns/PublicationFieldTypes.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/publications/src/Concerns/PublicationFieldTypes.php b/packages/publications/src/Concerns/PublicationFieldTypes.php index 936e8018eb8..ca48a4a5f81 100644 --- a/packages/publications/src/Concerns/PublicationFieldTypes.php +++ b/packages/publications/src/Concerns/PublicationFieldTypes.php @@ -25,7 +25,8 @@ enum PublicationFieldTypes: string case Array = 'array'; case Media = 'media'; case Text = 'text'; - case Tag = 'tag'; // TODO: Rename to "tags"? + /** @deprecated May be renamed to Tags to better fit usage */ + case Tag = 'tag'; case Url = 'url'; /** Get the default validation rules for this field type. */