From 3dba69a948c770b8057a8a19169998b6f9322aca Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Wed, 13 Mar 2024 18:15:32 +0100 Subject: [PATCH] Refactor component to use attribute merging --- .../views/components/navigation/navigation-link.blade.php | 6 ++++-- .../framework/tests/Unit/Views/NavigationMenuViewTest.php | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/framework/resources/views/components/navigation/navigation-link.blade.php b/packages/framework/resources/views/components/navigation/navigation-link.blade.php index 207172ff4ea..0460e6fb38f 100644 --- a/packages/framework/resources/views/components/navigation/navigation-link.blade.php +++ b/packages/framework/resources/views/components/navigation/navigation-link.blade.php @@ -1,4 +1,6 @@ -isActive() ? 'aria-current="page"' : '' !!} @class([ +except('item')->class([ 'navigation-link block my-2 md:my-0 md:inline-block py-1 text-gray-700 hover:text-gray-900 dark:text-gray-100', 'navigation-link-active border-l-4 border-indigo-500 md:border-none font-medium -ml-6 pl-5 md:ml-0 md:pl-0 bg-gray-100 dark:bg-gray-800 md:bg-transparent dark:md:bg-transparent' => $item->isActive() -])>{{ $item->getLabel() }} \ No newline at end of file +])->merge([ + 'aria-current' => ($item->isActive() ? 'page' : false), +])) }}>{{ $item->getLabel() }} \ No newline at end of file diff --git a/packages/framework/tests/Unit/Views/NavigationMenuViewTest.php b/packages/framework/tests/Unit/Views/NavigationMenuViewTest.php index a40d6782b33..18d9bfd7cbf 100644 --- a/packages/framework/tests/Unit/Views/NavigationMenuViewTest.php +++ b/packages/framework/tests/Unit/Views/NavigationMenuViewTest.php @@ -73,7 +73,7 @@ public function testNavigationMenuWithRootPages() $contents = $foo->compile(); $this->assertStringContainsString('