From 1f8c4b250f6e6169448990f406a9d7a6e5287004 Mon Sep 17 00:00:00 2001 From: Caen De Silva Date: Mon, 27 Nov 2023 17:24:56 +0100 Subject: [PATCH] Cleanup method and document logic reasoning --- .../Features/XmlGenerators/SitemapGenerator.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/framework/src/Framework/Features/XmlGenerators/SitemapGenerator.php b/packages/framework/src/Framework/Features/XmlGenerators/SitemapGenerator.php index 89e0b2cbc6e..0fb0f0e7663 100644 --- a/packages/framework/src/Framework/Features/XmlGenerators/SitemapGenerator.php +++ b/packages/framework/src/Framework/Features/XmlGenerators/SitemapGenerator.php @@ -110,12 +110,13 @@ protected function resolveRouteLink(Route $route): string { $baseUrl = Config::getNullableString('hyde.url'); - $canUseQualifiedUrl = filled($baseUrl) && ! str_starts_with($baseUrl, 'http://localhost'); + if (! filled($baseUrl) || str_starts_with($baseUrl, 'http://localhost')) { + // While the sitemap spec requires a full URL, we rather fall back + // to using relative links instead of using localhost links. - if ($canUseQualifiedUrl) { + return $route->getLink(); + } else { return Hyde::url($route->getOutputPath()); } - - return $route->getLink(); } }