Remove usage of ActiveSupport's #present? method #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces it with #empty?
tarcieri
force-pushed
the
tonyarcieri/remove-activesupport-method-usage
branch
from
25f6f13
to
ae53708
Compare
tarcieri
added a commit
that referenced
this pull request
Sep 7, 2015
…method-usage Remove usage of ActiveSupport's #present? method
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Oct 4, 2015
## 0.9.8 (2015-09-29) * [#260](httprb/http#258): Fixed global timeout persisting time left across requests when reusing connections. ([@zanker][]) ## 0.9.7 (2015-09-19) * [#258](httprb/http#258): Unified strategy for handling exception-based and exceptionless non-blocking I/O. Fixes SSL support on JRuby 9000. ([@tarcieri][]) ## 0.9.6 (2015-09-06) * [#254](httprb/http#254): Removed use of an ActiveSupport specific method #present? ([@tarcieri][]) ## 0.9.5 (2015-09-06) * [#252](httprb/http#252): Fixed infinite hang/timeout when a request contained more than ~16,363 bytes. ([@zanker][]) ## 0.9.4 (2015-08-26) * Fixes regression when body streaming was failing on some URIs. See #246. (@zanker) * Fixes require timeout statements. See #243. (@ixti) ## 0.9.3 (2015-08-19) * Fixed request URI normalization. See #246. (@ixti) - Avoids query component normalization - Omits fragment component in headline ## 0.9.2 (2015-08-18) * Fixed exceptionless NIO EOF handling. (@zanker) ## 0.9.1 (2015-08-14) * Fix params special-chars escaping. See #246. (@ixti) ## 0.9.0 (2015-07-23) * Support for caching removed. See #240. (@tarcieri) * JRuby 9000 compatibility
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Nov 6, 2015
## 0.9.8 (2015-09-29) * [#260](httprb/http#258): Fixed global timeout persisting time left across requests when reusing connections. ([@zanker][]) ## 0.9.7 (2015-09-19) * [#258](httprb/http#258): Unified strategy for handling exception-based and exceptionless non-blocking I/O. Fixes SSL support on JRuby 9000. ([@tarcieri][]) ## 0.9.6 (2015-09-06) * [#254](httprb/http#254): Removed use of an ActiveSupport specific method #present? ([@tarcieri][]) ## 0.9.5 (2015-09-06) * [#252](httprb/http#252): Fixed infinite hang/timeout when a request contained more than ~16,363 bytes. ([@zanker][]) ## 0.9.4 (2015-08-26) * Fixes regression when body streaming was failing on some URIs. See #246. (@zanker) * Fixes require timeout statements. See #243. (@ixti) ## 0.9.3 (2015-08-19) * Fixed request URI normalization. See #246. (@ixti) - Avoids query component normalization - Omits fragment component in headline ## 0.9.2 (2015-08-18) * Fixed exceptionless NIO EOF handling. (@zanker) ## 0.9.1 (2015-08-14) * Fix params special-chars escaping. See #246. (@ixti) ## 0.9.0 (2015-07-23) * Support for caching removed. See #240. (@tarcieri) * JRuby 9000 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces it with
#empty?