Fixed chunk writing if the data is bugger than our buffer (#251) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One related-looking test failure? (oh mocking IO...) Would be nice if we had a better strategy for write buffering in general. I'm pretty sure we run afoul of the pathological case for Nagle where do a small write immediately followed by another write. |
zanker
force-pushed
the
zanker/stress-tests
branch
from
46214fb
to
7869ff2
Compare
|
:( socket mocking. I want to redo the test suite somepoint and pull in the one we use for our internal stuff, since that has a lot of edge case handling already too. Test failure should be fixed |
|
LGTM 👍 |
tarcieri
added a commit
that referenced
this pull request
Sep 6, 2015
Fixed chunk writing if the data is bugger than our buffer (#251)
| while data.present? | ||
| length = @socket.write(data) | ||
| if data.length > length | ||
| data = data[length..-1] |
There was a problem hiding this comment.
This will allocate every time. I wonder if it would be possible to use #slice! here to reduce allocations. Or maybe we just need real ByteBuffers 😕
There was a problem hiding this comment.
We call this using @body as is, so we probably can't use slice!, unless we call dup beforehand.
Would need to benchmark to figure out if the optimization works out.
There was a problem hiding this comment.
Since Ruby strings are CoW anyway, this usage is probably efficient
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Oct 4, 2015
## 0.9.8 (2015-09-29) * [#260](httprb/http#258): Fixed global timeout persisting time left across requests when reusing connections. ([@zanker][]) ## 0.9.7 (2015-09-19) * [#258](httprb/http#258): Unified strategy for handling exception-based and exceptionless non-blocking I/O. Fixes SSL support on JRuby 9000. ([@tarcieri][]) ## 0.9.6 (2015-09-06) * [#254](httprb/http#254): Removed use of an ActiveSupport specific method #present? ([@tarcieri][]) ## 0.9.5 (2015-09-06) * [#252](httprb/http#252): Fixed infinite hang/timeout when a request contained more than ~16,363 bytes. ([@zanker][]) ## 0.9.4 (2015-08-26) * Fixes regression when body streaming was failing on some URIs. See #246. (@zanker) * Fixes require timeout statements. See #243. (@ixti) ## 0.9.3 (2015-08-19) * Fixed request URI normalization. See #246. (@ixti) - Avoids query component normalization - Omits fragment component in headline ## 0.9.2 (2015-08-18) * Fixed exceptionless NIO EOF handling. (@zanker) ## 0.9.1 (2015-08-14) * Fix params special-chars escaping. See #246. (@ixti) ## 0.9.0 (2015-07-23) * Support for caching removed. See #240. (@tarcieri) * JRuby 9000 compatibility
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Nov 6, 2015
## 0.9.8 (2015-09-29) * [#260](httprb/http#258): Fixed global timeout persisting time left across requests when reusing connections. ([@zanker][]) ## 0.9.7 (2015-09-19) * [#258](httprb/http#258): Unified strategy for handling exception-based and exceptionless non-blocking I/O. Fixes SSL support on JRuby 9000. ([@tarcieri][]) ## 0.9.6 (2015-09-06) * [#254](httprb/http#254): Removed use of an ActiveSupport specific method #present? ([@tarcieri][]) ## 0.9.5 (2015-09-06) * [#252](httprb/http#252): Fixed infinite hang/timeout when a request contained more than ~16,363 bytes. ([@zanker][]) ## 0.9.4 (2015-08-26) * Fixes regression when body streaming was failing on some URIs. See #246. (@zanker) * Fixes require timeout statements. See #243. (@ixti) ## 0.9.3 (2015-08-19) * Fixed request URI normalization. See #246. (@ixti) - Avoids query component normalization - Omits fragment component in headline ## 0.9.2 (2015-08-18) * Fixed exceptionless NIO EOF handling. (@zanker) ## 0.9.1 (2015-08-14) * Fix params special-chars escaping. See #246. (@ixti) ## 0.9.0 (2015-07-23) * Support for caching removed. See #240. (@tarcieri) * JRuby 9000 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.