markApproved, markRejected, ... functions incompatible with models with attributes with array casts

[koapeadu]

I have a model with an array cast on one attribute foo.

protected $casts = [
        'foo' => 'array',
];

But the SQL type is VARCHAR.
When the any of markApproved, markRejected, markPostponed, markPending is called, it causes the attributes array to be changed from

$attributes = [
    ...
    'foo' => '["mango","pineapple","pawpaw"]'
    ...
]

to

$attributes = [
    ...
    'foo' => [
        "mango", "pineapple", "pawpaw"
    ]
    ...
]

which leads to unexpected value exceptions when trying to save the model

[koapeadu]

Ok I was able to fix it by changing the $new->attributesToArray() to $new->attributes in the Moderatable trait.
So the markApproved function for example changes to

public function markApproved()
{
    $new = (new static)->newQueryWithoutScope(new ModerationScope())->approve($this->id);
    return $this->setRawAttributes($new->attributes); // instead of $this->setRawAttributes($new->attributesToArray())
}

@hootlex Kindly test this and update. Thanks

[koapeadu]

I submitted a PR to fix it. #45