-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span Events #66
Comments
P.S.: in the interim, this might be another good chance to use |
Hello, We will be closing this issue as it is a low priority for us. It is unlikely that we'll ever get to it, and so we'd like to set expectations accordingly. As we enter 2022 Q1, we are trimming our OSS backlog. This is so that we can focus better on areas that are more aligned with the OpenTelemetry-focused direction of telemetry ingest for Honeycomb. If this issue is important to you, please feel free to ping here and we can discuss/re-open. |
I'm interested in trying to use the concept of span events, which requires setting the
meta.span_type
to"span_event"
. As a first crack, I might try and repurpose aHoneycomb::Span
like:However,
Honeycomb::Span#send_internal
always clobbers the span type:beeline-ruby/lib/honeycomb/span.rb
Line 98 in 4713124
beeline-ruby/lib/honeycomb/span.rb
Lines 133 to 141 in 4713124
Plus
Honeycomb::Span
is going to include fields that don't make sense for span events.So of course, rather than bolt this onto the wrong data type, I propose there should be a new class,
Honeycomb::SpanEvent
. This could work much likeHoneycomb::Span
, but doesn't need things likeduration_ms
or children (right?). But it still needs things like the sampling hook, for example.Since span events are single point-in-time structured logs, I think the API for generating them could be something as simple as:
Then
Honeycomb::Client#add_event
(delegated to byHoneycomb.add_event
) would forward to the current span.I'd PR this, but I can't work on it right at the moment, and it seems like it would get hairy threading through the current
Trace
/Span
/Context
jenga (does it make sense to maybe haveclass SpanEvent < Span
and treat it mostly like any other span? 🤔). So I'm noting the idea / feature request for posterity. 😇The text was updated successfully, but these errors were encountered: