Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: sqrt #100

Closed
fxfactorial opened this issue Nov 8, 2021 · 4 comments · Fixed by #104
Closed

feature request: sqrt #100

fxfactorial opened this issue Nov 8, 2021 · 4 comments · Fixed by #104

Comments

@fxfactorial
Copy link

thank you

@holiman
Copy link
Owner

holiman commented Nov 8, 2021

Yup, I guess it fits.
The big.Int algo looks pretty tidy: https://github.com/golang/go/blob/master/src/math/big/nat.go#L1213

@fxfactorial
Copy link
Author

Perfect thank you

@holiman
Copy link
Owner

holiman commented Nov 8, 2021

Wait what? Why did you close it.

I meant that the feature request was a good feature request, and that if we want to add it, we could easily use the implementation from big.Int.

@fxfactorial fxfactorial reopened this Nov 8, 2021
@fxfactorial
Copy link
Author

ah, I thought you meant like "go implement yourself" , my bad

sure, my team will try to upstream the impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants