Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDPG and SAC for discrete action space. #422

Closed
soloist96 opened this issue Jul 26, 2019 · 4 comments
Closed

DDPG and SAC for discrete action space. #422

soloist96 opened this issue Jul 26, 2019 · 4 comments
Labels
duplicate This issue or pull request already exists question Further information is requested

Comments

@soloist96
Copy link

[question] Is there any reason why DDPG and SAC don't have the implementation for discrete action space? And will appreciate it there are any suggestions for applying the DDPG with continuous action space on the discrete one. Thanks!

@araffin araffin added duplicate This issue or pull request already exists question Further information is requested labels Jul 26, 2019
@araffin
Copy link
Collaborator

araffin commented Jul 26, 2019

Hello,
For DDPG, you can already find an answer here: #37
For SAC, the implementation with discrete actions is not trivial and it was developed to be used on robots, so with continuous actions. Those are the main reason. Meanwhile, if you want to work with discrete actions, you have plenty of other algorithms that can do that (ACER, PPO, DQN, A2C, ACKTR, ...).

@araffin araffin closed this as completed Aug 23, 2019
@cosmir17
Copy link

cosmir17 commented Dec 5, 2020

It was more than a year ago. Any news on this topic recently @araffin ?
It would be nice if SAC can take discrete action space input.

@araffin
Copy link
Collaborator

araffin commented Dec 5, 2020

We have an issue about that in Stable-Baselines3 repo: DLR-RM/stable-baselines3#157

But I would favor QR-DQN first in the contrib repo.

@cosmir17
Copy link

cosmir17 commented Dec 5, 2020

Thank you for letting me know @araffin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants