Add DOMPurify to sanitize HTML #196
Conversation
Non breacking new feature (disabled by default)
|
I should have added that it's a work in progress. Sorry for the trouble. Will deliver asap |
|
Ready to be merged, no breacking change => just a minor bump :) |
|
Could someone release v4.1.0 following the merge of this PR? |
Please let me know. |
lib/renderer.js
Outdated
| const createDOMPurify = require('dompurify'); | ||
| const { JSDOM } = require('jsdom'); |
There was a problem hiding this comment.
Is it possible to only require dompurify when the option is enabled?
| const createDOMPurify = require('dompurify'); | |
| const { JSDOM } = require('jsdom'); | |
| let JSDOM; | |
| let createDOMPurify; | |
| if (config.dompurify) { | |
| createDOMPurify = require('dompurify'); | |
| JSDOM = require('jsdom').JSDOM; | |
| } |
This could speed up cold start performance.
There was a problem hiding this comment.
Ah, the suggestion here is just for demonstration. The require part should be added after the config is read.
@yoshinorin you can create a release |
Non breacking new feature (disabled by default)
Will need a Minor version bump.
Once done, the plan is to enable it by default, to be safe by default :)