Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve coverage #505

Merged
merged 3 commits into from
May 18, 2024
Merged

test: improve coverage #505

merged 3 commits into from
May 18, 2024

Conversation

D-Sketon
Copy link
Member

@D-Sketon D-Sketon commented Apr 21, 2024

check list

  • Add test cases for the changes.
  • Passed the CI test.

Description

Additional information

hexojs/hexo#5475

@coveralls
Copy link

coveralls commented Apr 21, 2024

Coverage Status

coverage: 92.015% (+8.0%) from 84.03%
when pulling f816096 on D-Sketon:test/old
into ca317b2 on hexojs:master.

@D-Sketon D-Sketon marked this pull request as draft April 21, 2024 03:43
@D-Sketon D-Sketon marked this pull request as ready for review April 21, 2024 05:27
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/scripts/hexo.ts Outdated Show resolved Hide resolved
@stevenjoezhang
Copy link
Member

Some tests on Windows failed
截屏2024-05-14 00 53 30

@D-Sketon
Copy link
Member Author

I don't know why, it works fine on my windows laptop with node 18.

@uiolee uiolee merged commit e1f7178 into hexojs:master May 18, 2024
11 of 14 checks passed
@D-Sketon D-Sketon deleted the test/old branch May 18, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants