Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: known issue for listener using proxy_protocol _behavior #27628

Merged
merged 15 commits into from
Jul 2, 2024
Merged

docs: known issue for listener using proxy_protocol _behavior #27628

merged 15 commits into from
Jul 2, 2024

Conversation

peteski22
Copy link

@peteski22 peteski22 commented Jun 27, 2024 •
edited
Loading

Description

Documents a known issue which impacts various versions of Vault.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@peteski22 peteski22 added docs pr/no-changelog pr/no-milestone hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jun 27, 2024
@peteski22 peteski22 requested a review from schavis June 27, 2024 16:01
@peteski22 peteski22 requested a review from a team as a code owner June 27, 2024 16:01
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

Peter Wilson added 2 commits June 27, 2024 17:04
relative links
1344ec7
Merge branch 'peteski22/VAULT-6803/docs/known-issue' of github.com:ha…
18fc214 
…shicorp/vault into peteski22/VAULT-6803/docs/known-issue
@peteski22 peteski22 requested a review from a team June 27, 2024 18:05
VioletHynes
VioletHynes approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great detail -- and sorry for the confusion on the versions.

@peteski22 peteski22 requested a review from schavis July 1, 2024 09:31
@peteski22 peteski22 added backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x labels Jul 1, 2024
@peteski22 peteski22 requested a review from yhyakuna July 2, 2024 16:50
@schavis
Update website/content/partials/known-issues/config_listener_proxy_pr…
f512e1a 
…otocol_behavior_issue.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@peteski22 peteski22 requested a review from schavis July 2, 2024 18:47
@peteski22 peteski22 removed backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent labels Jul 2, 2024
@schavis schavis self-requested a review July 2, 2024 18:58
schavis
schavis approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@schavis schavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock publication. Please be sure to apply the suggestions before merging.

Peter Wilson and others added 2 commits July 2, 2024 20:37
@schavis
Update website/content/partials/known-issues/config_listener_proxy_pr…
07b321c 
…otocol_behavior_issue.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@schavis
Update website/content/partials/known-issues/config_listener_proxy_pr…
106fdbb 
…otocol_behavior_issue.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@peteski22 peteski22 merged commit a49c892 into main Jul 2, 2024
31 of 32 checks passed
@peteski22 peteski22 deleted the peteski22/VAULT-6803/docs/known-issue branch July 2, 2024 20:52
Merged
6 tasks
peteski22 pushed a commit that referenced this pull request Jul 3, 2024
@schavis
docs: known issue for listener using proxy_protocol _behavior (#27628)
b5c5ffe 
* docs: known issue for listener proxy protocol behavior

* relative links

* update text

* Update website/content/partials/known-issues/config_listener_proxy_protocol_behavior_issue.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* change one of the uses of 'this'

* Update website/content/partials/known-issues/config_listener_proxy_protocol_behavior_issue.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/partials/known-issues/config_listener_proxy_protocol_behavior_issue.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
peteski22 pushed a commit that referenced this pull request Jul 3, 2024
@hc-github-team-secure-vault-core @schavis
docs: known issue for listener using proxy_protocol _behavior (#27628…
73079ee 
…) (#27665)

* docs: known issue for listener proxy protocol behavior

---------

Co-authored-by: Peter Wilson <peter.wilson@hashicorp.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VioletHynes VioletHynes VioletHynes approved these changes

@schavis schavis schavis approved these changes

@yhyakuna yhyakuna Awaiting requested review from yhyakuna

Assignees
No one assigned
Labels
backport/1.17.x docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peteski22 @VioletHynes @schavis