UI: Use Client Count export API #27455
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
| async generateCsvData() { | ||
| const adapter = this.store.adapterFor('clients/activity'); | ||
| const currentNs = this.namespace.path; | ||
| const { startTimestamp, endTimestamp, selectedNamespace } = this.args; |
There was a problem hiding this comment.
CC work has had so many iterations 🫠 - these start/end timestamps update when the date params change, right?
| return `This export will include the namespace path, mount path and associated total entity, non-entity${ | ||
| isSecretsSyncActivated ? ', ACME and secrets sync clients' : ' and ACME clients' | ||
| } for the ${this.formattedEndDate ? 'date range' : 'month'} below.`; | ||
| exportChartData = task({ drop: true }, async (filename) => { |
There was a problem hiding this comment.
Is there a difference between using this syntax vs:
@task({ drop: true })
*exportChartData(filename) {...}(aside from this changing the await below to a yield)
There was a problem hiding this comment.
What I used is the latest recommended syntax -- in my experience, it also has a better TS experience (although that is not relevant here) https://ember-concurrency.com/docs/task-concurrency
| */ | ||
|
|
||
| /** | ||
| * queryParamString converts an object to a query param string with URL encoded keys and values. |
There was a problem hiding this comment.
great idea making this a util!
| import queryParamString from 'vault/utils/query-param-string'; | ||
| import { module, test } from 'qunit'; | ||
|
|
||
| module('Unit | Utility | query-param-string', function () { |
This reverts commit d9a4d40.
| return resp.blob(); | ||
| } | ||
| // If it's an empty response (eg 204), there's no data so return an error | ||
| errorMsg = 'no data to export in provided time range.'; |
There was a problem hiding this comment.
I'm matching the casing of the API error messages, which don't have capitalization
Description
This PR updates the Client Count Dashboard to use the dedicated export API. Relies on enterprise PR 6171
sudocapabilities to export at the given namespaceUpdated modal content
Updated CSV content
Previous CSV content
