Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodata should not be set for model_ds #107

Closed
bdestombe opened this issue Oct 28, 2022 · 1 comment
Closed

nodata should not be set for model_ds #107

bdestombe opened this issue Oct 28, 2022 · 1 comment
Milestone
Release v0.4.0

Comments

@bdestombe
Copy link
Collaborator

bdestombe commented Oct 28, 2022 •
edited
Loading

The nodata attribute should only be set for dataarrays of integers and not for datasets. nlmod.mdims.to_model_ds returns a ds with nodata as attribute.
@dbrakenhoff
Copy link
Collaborator

Fixed in #108

@dbrakenhoff dbrakenhoff added this to the Release v0.4.0 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v0.4.0
Development

No branches or pull requests
2 participants
@dbrakenhoff @bdestombe