Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vet: various cleanups #6780

Merged
merged 4 commits into from
Nov 10, 2023
Merged

vet: various cleanups #6780

merged 4 commits into from
Nov 10, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 10, 2023

Various vet.sh improvements/cleanups:

  • Use staticcheck for pkg comments instead of special code.
  • Remove golint use (it is deprecated & very slow).
  • Re-add deprecation warnings and update exclusions.
  • Add all checkers to staticcheck (e.g. mismatched receivers, underscores).
  • Add a manual check for misspelled test functions that prevent running.

And some fixes:

  • Mismatched receiver names
  • Test function misspelled that prevented it from running
  • Duplicate imports

RELEASE NOTES: n/a

- Use staticcheck for pkg comments instead of special code.
- Remove golint use (it is deprecated & very slow).
- Re-add deprecation warnings and update exclusions.
- Add all checkers to staticcheck (e.g. mismatched receivers, underscores).
- Add a manual check for misspelled test functions that prevent running.
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #6780 (afbb0ad) into master (591c481) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6780      +/-   ##
==========================================
- Coverage   83.35%   83.28%   -0.07%     
==========================================
  Files         285      285              
  Lines       30967    30967              
==========================================
- Hits        25811    25791      -20     
- Misses       4078     4092      +14     
- Partials     1078     1084       +6     

see 18 files with indirect coverage changes

Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 2 minor comments;

Also, does vet complain about go.work for you?

test/end2end_test.go Show resolved Hide resolved
test/end2end_test.go Show resolved Hide resolved
vet.sh Show resolved Hide resolved
@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Nov 10, 2023
@dfawley dfawley merged commit 8b17a4d into grpc:master Nov 10, 2023
14 checks passed
@dfawley dfawley deleted the nocmt branch November 10, 2023 21:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants