-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vet: various cleanups #6780
Merged
Merged
vet: various cleanups #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use staticcheck for pkg comments instead of special code. - Remove golint use (it is deprecated & very slow). - Re-add deprecation warnings and update exclusions. - Add all checkers to staticcheck (e.g. mismatched receivers, underscores). - Add a manual check for misspelled test functions that prevent running.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6780 +/- ##
==========================================
- Coverage 83.35% 83.28% -0.07%
==========================================
Files 285 285
Lines 30967 30967
==========================================
- Hits 25811 25791 -20
- Misses 4078 4092 +14
- Partials 1078 1084 +6 |
arvindbr8
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only 2 minor comments;
Also, does vet complain about go.work
for you?
arvindbr8
approved these changes
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various
vet.sh
improvements/cleanups:And some fixes:
RELEASE NOTES: n/a