From 0bbb5fc3580f2a0aed53953281821d3697bbbd05 Mon Sep 17 00:00:00 2001 From: Timo Pollmeier Date: Tue, 12 Oct 2021 17:35:37 +0200 Subject: [PATCH 1/2] Fix SQL format string in create_config_internal The format string contained a placeholder for the removed type field. --- src/manage_sql_configs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/manage_sql_configs.c b/src/manage_sql_configs.c index 8e23b013a..6ca6b5870 100644 --- a/src/manage_sql_configs.c +++ b/src/manage_sql_configs.c @@ -2491,7 +2491,7 @@ create_config_internal (int check_access, const char *config_id, " creation_time, modification_time, usage_type, predefined)" " VALUES (%s%s%s, '%s'," " (SELECT id FROM users WHERE users.uuid = '%s')," - " '%s', '%s', '%s', m_now (), m_now (), '%s', %i);", + " '%s', '%s', m_now (), m_now (), '%s', %i);", config_id ? "'" : "", config_id ? config_id : "make_uuid ()", config_id ? "'" : "", @@ -2508,7 +2508,7 @@ create_config_internal (int check_access, const char *config_id, " creation_time, modification_time, usage_type, predefined)" " VALUES (%s%s%s, '%s'," " (SELECT id FROM users WHERE users.uuid = '%s')," - " '%s', '', '%s', m_now (), m_now (), '%s', %i);", + " '', '%s', m_now (), m_now (), '%s', %i);", config_id ? "'" : "", config_id ? config_id : "make_uuid ()", config_id ? "'" : "", From fd0e3e156c54f0e2885c542a49d43dc1fcaa9e5a Mon Sep 17 00:00:00 2001 From: Timo Pollmeier Date: Tue, 12 Oct 2021 17:42:27 +0200 Subject: [PATCH 2/2] Amend CHANGELOG for create_config_internal fix --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 191968592..a8194d52a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,7 +27,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Removed OVAL definitions from GMP and gvmd documentation [1551](https://github.com/greenbone/gvmd/pull/1551) - Removed the Business Process Map from gvmd [1627](https://github.com/greenbone/gvmd/pull/1627) - Removed ifaces element from users [#1676](https://github.com/greenbone/gvmd/pull/1676) -- Removed OSP scanners from gvmd [#1689](https://github.com/greenbone/gvmd/pull/1689) [#1691](https://github.com/greenbone/gvmd/pull/1691) [#1694](https://github.com/greenbone/gvmd/pull/1694) +- Removed OSP scanners from gvmd [#1689](https://github.com/greenbone/gvmd/pull/1689) [#1691](https://github.com/greenbone/gvmd/pull/1691) [#1694](https://github.com/greenbone/gvmd/pull/1694) [#1701](https://github.com/greenbone/gvmd/pull/1701) [Unreleased]: https://github.com/greenbone/gvmd/compare/gvmd-21.04...master