Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render names of building entrances #740

Open
matthijsmelissen opened this issue Jul 19, 2014 · 19 comments
Open

Render names of building entrances #740

matthijsmelissen opened this issue Jul 19, 2014 · 19 comments

Comments

@matthijsmelissen
Copy link
Collaborator

Nodes/ways with building=entrance should be rendered at z18 as a tiny grey label, similar to housenumbers/housenames but possibly smaller font.

A popular use for osm is showing people how to get to your home and in the "east Germany" style giant blocks of flats the entrance/stairwell name is an important data point.

See also https://trac.openstreetmap.org/ticket/3498.

@matthijsmelissen matthijsmelissen added this to the 3.x - Needs upgrade to mapnik or openstreetmap-carto.style milestone Jul 19, 2014
@matthijsmelissen
Copy link
Collaborator Author

The building=entrance tag is superseded by the entrance=* scheme. However, the entrance key is not in the database. We will therefore postpone this to 3.x.

@kvlahromei
Copy link

I would also recommend to render that objects (maybe both tagging schemes for some time) as it shows that OSM has highly detailed data and the entrance is (IMHO) a important info for big buildings (campus, malls, hospitals, ...) on sites to plan your route and on which side you need to enter.

As this seems to be a simple node selector and symbol, I don't understand why we schedule it for 3.x as AFAIK there is no Mapnik source patch nessesary? Can anbody please explain if this is useful?

@HolgerJeromin
Copy link
Contributor

The milestone is named "upgrade of mapnik or openstreetmap-carto.style". Here we need the entrance key in the database.

@matthijsmelissen
Copy link
Collaborator Author

These are they keys we currently have in the database: https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style The entrance key is not there, and that's the key we need, if I'm not mistaken. As we'd need to reload the database with new keys for this, this is scheduled for 3.0. See also #1243.

@kvlahromei
Copy link

Thanks for the feedback. I'm very ok with waiting for 3.0 for altering the DB import schema.

But as key:building seems to be already present, might we add building=entrance for now and replace it later on with the new tagging schema? Currently the old schema is still supported by all editors and visualized.

@HolgerJeromin
Copy link
Contributor

building=entrance is deprecated since a few weeks in josm.
Right now we have 10x more entrances=* than building=entrance. Rendering the old tag would promote a retagging to the old schema.

@dieterdreist
Copy link

2015-01-21 13:17 GMT+01:00 Holger Jeromin notifications@github.com:

building=entrance is deprecated since a few weeks
https://josm.openstreetmap.de/changeset/7795/josm in josm.
Right now we have 10x
http://taginfo.openstreetmap.org/compare/building=entrance/entrance
more entrances=* than building=entrance. Rendering the old tag would
promote a retagging to the old schema.

+1, building=entrance is deprecated for years in the wiki and db.

@tpikonen
Copy link
Contributor

Does the fix to #2488 (released with v4.4.0) also fix this issue?

addr:housename, addr:housenumber and addr:unit are now rendered also on entrance nodes.

@kocio-pl
Copy link
Collaborator

I guess not - this is about "gate A" for example and not about addresses.

@ghost07tula
Copy link

It seems the time has come to implement this feature.

@HolgerJeromin
Copy link
Contributor

entrance type and access is rendered by merged #2936
So only the name=* is missing from this issue.

@kocio-pl
Copy link
Collaborator

We should decide what zoom level, what color (brown probably) and probably when and how to use name and ref for labels. Anybody willing to write the code or just has some ideas to move it forward?

@Tomasz-W
Copy link

related to #3038

@jeisenbe
Copy link
Collaborator

What tag is being requested for rendering in this issue?

Here are the frequent combinations: (https://taginfo.openstreetmap.org/keys/?key=entrance#combinations):

227, 242 - 10.54% | ref
148, 925 - 6.91% | addr:flats
56, 224 - 2.61% | name

addr:unit is less common, and already rendered now.

The ref=* tag appears to be the most common, on over 10% of the entrance=* features.

Has anyone looked into how this is being used, and how it differs from addr:unit or addr:flats?

@jeisenbe
Copy link
Collaborator

We now render addr:flats since PR #4082

This will solve some of these cases, but not for the larger number of entrances which have a ref=* or the smaller number that have a name. Should we just render the ref=*?

@Adamant36
Copy link
Contributor

Should we just render the ref=*?

Yes.

@richlv
Copy link
Contributor

richlv commented May 21, 2020

The ref=* tag appears to be the most common, on over 10% of the entrance=* features.

Has anyone looked into how this is being used, and how it differs from addr:unit or addr:flats?

I believe it's mostly the case of numbered or "lettered" entrances, often in addition to flat ranges.
For example, an entrance could have addr:flats=1-20, and ref=1, or ref=A.
There is/was addr:entrance, which seems a bit more descriptive - but then it might be fragmenting the keyspace too much.

Thinking about a few specific examples, such entrances would need to have both addr:flats and ref rendered.

@dieterdreist
Copy link

dieterdreist commented May 22, 2020 via email

@Adamant36
Copy link
Contributor

another case are huge sites (factories, stadiums, shopping centers, beach resorts, etc.) which have many entrances and might use letters to “number” them

It's hard to tell if those would be cases for the name or ref tag. I've had a few discussions with people in relation to similar things, like descriptive or reference names for objects in state parks on official maps and I could never figure out what the correct route to go with it was. I could see a for either name or ref in those cases.

If the vast majority of entrance names are numbers, it would probably be better to label them with the ref tag instead. I could see a use for that in cases of emergency exists or things like loading docks. I don't think the name tag, if it's a number or not, is appropriate in those situations though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

13 participants