Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider rendering forest fill under any other landuse #4371

Closed
matkoniecz opened this issue Apr 13, 2021 · 6 comments
Closed

Consider rendering forest fill under any other landuse #4371

matkoniecz opened this issue Apr 13, 2021 · 6 comments

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Apr 13, 2021

There are forest symbols, designed for being visible over landuse=residential and other land use.

But in some cases also green fill is displayed on top of mapped landuse (when forest area is smaller than competing areas)

Expected behavior

Green forest fill is rendered below landuse=residential (and other) while symbols still are rendered above.

Actual behavior

Sometimes green fill obscures landues

Links and screenshots illustrating the problem

https://www.openstreetmap.org/way/711432832#map=19/41.67983/-88.55266

landuse=residential being marked:

screen02
screen04

@ZeLonewolf
Copy link
Contributor

It is common to have minor areas of wood/forest on top of landuse=residential areas. In those cases, I think the current behavior works well.

@cliffordsnow
Copy link

I like how the current rendering works. If nothing else, the basemap look nicer when we render wood/forest on top of landuse.

@talllguy
Copy link

Old but relevant issues about these overlaps #888 and #1136. The size of the area matters. I personally have mapped a lot of landuse=residential to the property/subdivision boundary based on the admin_level wiki. It is common to have tree areas inside these residential areas. I think the green trees should show on top of the grey residential fill in those cases.

@matkoniecz
Copy link
Contributor Author

I like how the current rendering works. If nothing else, the basemap look nicer when we render wood/forest on top of landuse.

That is also potential solution, if that proposed change would be rejected I will be at least able to demonstrate that fix was considered and rejected as worse than problem once someone complains again :)

AKA everything is more complicate than expected

@imagico
Copy link
Collaborator

imagico commented Apr 14, 2021

I would be against removing wood/forest from the size based drawing order of the landcover layer. As @talllguy said having smaller wood areas show up within a residential area is important for proper mapper feedback. Yes, we have the pattern overlay, but that would not really be a proper display of the wooded area in such a case - and confusing in comparison to other small grained landcover mapping within a residential area like grass/garden.

I think the sized based drawing order plus the separate pattern overlay is the best way to be explicit about overlaps in mapping in a generic and comprehensible form.

@matkoniecz
Copy link
Contributor Author

heh, that was quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants