Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for historic=fort #2871

Closed
fqdb opened this issue Sep 27, 2017 · 17 comments
Closed

Add rendering for historic=fort #2871

fqdb opened this issue Sep 27, 2017 · 17 comments

Comments

@fqdb
Copy link

fqdb commented Sep 27, 2017

Seeing as rendering for castles is already proposed, please also add support for historic=fort.

Made a possible design for an icon as well, needs some polishing of course, anyone is free to use it if they feel the need to contribute.
fort.pdf

@kocio-pl
Copy link
Collaborator

I'm not sure what this icon means, so this could be tweaked, but we need 14x14 px SVG (pixel aligned) version anyway.

@kocio-pl kocio-pl added this to the New features milestone Sep 27, 2017
@kocio-pl
Copy link
Collaborator

This tag has 2888 uses and a wiki page:

https://wiki.openstreetmap.org/wiki/Tag%3Ahistoric%3Dfort

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 3, 2018

What about Osmic icon design:

https://github.com/gmgeo/osmic/blob/master/tourism/fort-14.svg

Another idea would be to draw a shape of "half star", resembling the typical shape of the fort from the aerial view.

@Tomasz-W
Copy link

Tomasz-W commented Feb 4, 2018

I though about this: http://1.bp.blogspot.com/-_xfoktodFMY/UJksjLQlDRI/AAAAAAAAAJs/EPObvzNgtsQ/s1600/VaubanPlan.jpg

Give me feedback is there a need to make an icon project with this shape.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 4, 2018

Something like this could work, but it might be hard at 14 px.

@Tomasz-W
Copy link

Tomasz-W commented Feb 4, 2018

I've tried also rectangle-shaped and pentagon-shaped fort outline, but it actually didn't work. For example, five-armed shape
http://www.syler.com/SiegeWarfare/basicconcepts/imgs4BasicConcepts/StarFort01.jpg
in 14x14 gives just simple star: historic fort

@StyXman
Copy link
Contributor

StyXman commented Feb 4, 2018

I made this icon for my style:

https://github.com/StyXman/elevation/blob/master/osm-carto/symbols/local/fort.svg

Do whatever you want with it, OSM gets any permisison from me :)

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 5, 2018

Thanks. 😄 How would it look like with 14 px?

@Tomasz-W Have you tried something like this?:
https://wiki.openstreetmap.org/wiki/File:Castle_fortress.png

It wouldn't look like a simple star because the inner part is empty and the shape is stretched.

@Tomasz-W
Copy link

Tomasz-W commented Feb 5, 2018

@kocio-pl:
pobrany plik (Osmic)
pobrany plik2 (@StyXman )
svg historic fort styxman (@StyXman without inner part)
historic fort (star shape without inner part)

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 5, 2018

Thanks for testing them! 3 looks quite promising for me, but it's based on rectangle instead of pentagon. Could you test pentagon with similar features?

@Tomasz-W
Copy link

Tomasz-W commented Feb 5, 2018

I've made corner elements a little bit bigger, but it's still not working for me:

historic fort3

14x14: historic fort

If someone wants to tune it up, here is the Gist: https://gist.github.com/Tomasz-W/615d2766d2b7e9c4295cd11cb998c8de

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 5, 2018

Maybe with a thin line on top instead of top feature would be better? It would be isosceles trapezoid then instead of pentagon.

@Tomasz-W
Copy link

Tomasz-W commented Feb 5, 2018

@kocio-pl Did you mean this?
historic fort linia 2
14x14: historic fort linia

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 5, 2018

Yes, with thinner line on the top (to show the side where the fort connects with the city for example). It looks quite good, but I'm thinking also about other variations:

  • 1 thin line on top and 4 thick walls on the bottom (instead of 3 thick walls)
  • the same (3 or 4 thick walls), but with with thick elements (small thick rectangles) in the middle of thick walls (instead of on nodes/vertexes)

I hope this is more or less clear... 😃

@Tomasz-W
Copy link

Tomasz-W commented Feb 5, 2018

I'm not sure if I understand it correctly, so I'm uploading both versions (trapezoid and pentagram) on Gist. Please tune it up on your own hand.
https://gist.github.com/Tomasz-W/0458d47f40b74c06b81888ba696cc6f1

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 5, 2018

I think this is even better than the last one and would fit the rest of castle/palace icons (see #744 (comment)). Original Osmic fort icon also fits them of course, but is less readable at 14 px.
20) fort-20
24) fort-24
25) fort-25

@kocio-pl
Copy link
Collaborator

@Tomasz-W Thanks for your design ideas, it helped me a lot to have a reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants