-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for historic=fort #2871
Comments
I'm not sure what this icon means, so this could be tweaked, but we need 14x14 px SVG (pixel aligned) version anyway. |
This tag has 2888 uses and a wiki page: |
What about Osmic icon design: https://github.com/gmgeo/osmic/blob/master/tourism/fort-14.svg Another idea would be to draw a shape of "half star", resembling the typical shape of the fort from the aerial view. |
I though about this: http://1.bp.blogspot.com/-_xfoktodFMY/UJksjLQlDRI/AAAAAAAAAJs/EPObvzNgtsQ/s1600/VaubanPlan.jpg Give me feedback is there a need to make an icon project with this shape. |
Something like this could work, but it might be hard at 14 px. |
I've tried also rectangle-shaped and pentagon-shaped fort outline, but it actually didn't work. For example, five-armed shape |
I made this icon for my style: https://github.com/StyXman/elevation/blob/master/osm-carto/symbols/local/fort.svg Do whatever you want with it, OSM gets any permisison from me :) |
Thanks. 😄 How would it look like with 14 px? @Tomasz-W Have you tried something like this?: It wouldn't look like a simple star because the inner part is empty and the shape is stretched. |
Thanks for testing them! 3 looks quite promising for me, but it's based on rectangle instead of pentagon. Could you test pentagon with similar features? |
I've made corner elements a little bit bigger, but it's still not working for me: If someone wants to tune it up, here is the Gist: https://gist.github.com/Tomasz-W/615d2766d2b7e9c4295cd11cb998c8de |
Maybe with a thin line on top instead of top feature would be better? It would be isosceles trapezoid then instead of pentagon. |
@kocio-pl Did you mean this? |
Yes, with thinner line on the top (to show the side where the fort connects with the city for example). It looks quite good, but I'm thinking also about other variations:
I hope this is more or less clear... 😃 |
I'm not sure if I understand it correctly, so I'm uploading both versions (trapezoid and pentagram) on Gist. Please tune it up on your own hand. |
I think this is even better than the last one and would fit the rest of castle/palace icons (see #744 (comment)). Original Osmic fort icon also fits them of course, but is less readable at 14 px. |
@Tomasz-W Thanks for your design ideas, it helped me a lot to have a reference. |
Seeing as rendering for castles is already proposed, please also add support for historic=fort.
Made a possible design for an icon as well, needs some polishing of course, anyone is free to use it if they feel the need to contribute.
fort.pdf
The text was updated successfully, but these errors were encountered: