Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source IP for connection in multiplexer error logging #8049

Closed
pschisa opened this issue Aug 24, 2021 · 1 comment · Fixed by #32712
Closed

Add source IP for connection in multiplexer error logging #8049

pschisa opened this issue Aug 24, 2021 · 1 comment · Fixed by #32712
Labels
c-af Internal Customer Reference c-aw Internal Customer Reference c-m Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements ux

Comments

@pschisa
Copy link
Contributor

pschisa commented Aug 24, 2021

What

The request is to add the source IP and port for the connection causing the issue in the following error message so that the source of the error message can be identified and resolved. Otherwise, the logs are spammed full of these messages and it is very difficult to track down the source to stop them.

Failed to retrieve client pool. Client cluster cluster-name, target cluster cluster-name2, error:
ERROR REPORT:
Original Error: *trace.NotFoundError key "/authorities/host/cluster-name" is not found
Stack Trace:
  /go/src/github.com/gravitational/teleport/lib/backend/memory/memory.go:186 github.com/gravitational/teleport/lib/backend/memory.(*Memory).Get
  /go/src/github.com/gravitational/teleport/lib/backend/report.go:161 github.com/gravitational/teleport/lib/backend.(*Reporter).Get
  /go/src/github.com/gravitational/teleport/lib/backend/wrap.go:89 github.com/gravitational/teleport/lib/backend.(*Wrapper).Get
  /go/src/github.com/gravitational/teleport/lib/services/local/trust.go:207 github.com/gravitational/teleport/lib/services/local.(*CA).GetCertAuthority
  /go/src/github.com/gravitational/teleport/lib/cache/cache.go:942 github.com/gravitational/teleport/lib/cache.(*Cache).GetCertAuthority
  /go/src/github.com/gravitational/teleport/lib/auth/middleware.go:571 github.com/gravitational/teleport/lib/auth.ClientCertPool
  /go/src/github.com/gravitational/teleport/lib/auth/middleware.go:265 github.com/gravitational/teleport/lib/auth.(*TLSServer).GetConfigForClient
  /opt/go/src/crypto/tls/handshake_server.go:141 crypto/tls.(*Conn).readClientHello
  /opt/go/src/crypto/tls/handshake_server.go:40 crypto/tls.(*Conn).serverHandshake
  /opt/go/src/crypto/tls/conn.go:1362 crypto/tls.(*Conn).Handshake
  /go/src/github.com/gravitational/teleport/lib/multiplexer/tls.go:144 github.com/gravitational/teleport/lib/multiplexer.(*TLSListener).detectAndForward
  /opt/go/src/runtime/asm_amd64.s:1374 runtime.goexit
User Message: key "/authorities/host/cluster-name" is not found.
@pschisa pschisa added feature-request Used for new features in Teleport, improvements to current should be #enhancements ux c-aw Internal Customer Reference labels Aug 24, 2021
@russjones russjones added the A0 label Aug 25, 2021
@pschisa
Copy link
Contributor Author

pschisa commented Nov 2, 2021

It would be nice if other multiplexer errors also included source IP. For example, the following error would be much easier to hunt down if the source IP:port of the connection was listed

WARN [MXTLS:1]   Handshake failed. error:[remote error: tls: bad certificate] multiplexer/tls.go:146

@pschisa pschisa added the c-m Internal Customer Reference label Nov 2, 2021
@pschisa pschisa changed the title Add source IP for connection in key "/authorities/host/cluster-name" is not found logging Add source IP for connection in multiplexer error logging Nov 2, 2021
@pschisa pschisa added the c-af Internal Customer Reference label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-af Internal Customer Reference c-aw Internal Customer Reference c-m Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants