Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If serie don't have data for requested interval, result should have proper time step #26

Open
Civil opened this issue Jan 19, 2015 · 1 comment

Comments

@Civil
Copy link

Civil commented Jan 19, 2015

vladimir-smirnov-sociomantic@555f974

If you request metric without any usable slices (e.x. no data for a long time and everything was rolled up out of the disk, but metadata still there) - you'll have resulting list with timeStep = 1, which isn't that good (it'll require recalculation of this slice on later stages). With this patch, ceres will return slice with more proper time steps (will look for them in the config file or use default one, instead of '1').

Though in current form it depends on dkulikovskiy's branch, because this commit also improves his detection of unneeded slices.

@iain-buclaw-sociomantic
Copy link
Contributor

Confirmed, however this would only apply if you request the data outside of graphite, as normally if a node does not hasDataForInterval() then graphite won't bother looking it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants