From 684e4f73eb8ac3691c617a8c1e4e56a4ae5079ba Mon Sep 17 00:00:00 2001
From: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Date: Thu, 8 Jul 2021 15:14:39 +0530
Subject: [PATCH] fix a panic in compactor when retention is not enabled

---
 pkg/storage/stores/shipper/compactor/compactor.go | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/pkg/storage/stores/shipper/compactor/compactor.go b/pkg/storage/stores/shipper/compactor/compactor.go
index 65174f9316a2..5799438e5ec5 100644
--- a/pkg/storage/stores/shipper/compactor/compactor.go
+++ b/pkg/storage/stores/shipper/compactor/compactor.go
@@ -198,7 +198,12 @@ func (c *Compactor) CompactTable(ctx context.Context, tableName string) error {
 	}
 
 	interval := extractIntervalFromTableName(tableName)
-	err = table.compact(c.expirationChecker.IntervalHasExpiredChunks(interval))
+	intervalHasExpiredChunks := false
+	if c.cfg.RetentionEnabled {
+		intervalHasExpiredChunks = c.expirationChecker.IntervalHasExpiredChunks(interval)
+	}
+
+	err = table.compact(intervalHasExpiredChunks)
 	if err != nil {
 		level.Error(util_log.Logger).Log("msg", "failed to compact files", "table", tableName, "err", err)
 		return err