From 074a988a5886897dc3f8e075d0b012d3fa78047b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aur=C3=A9lien=20Rainone?= Date: Sat, 19 Sep 2020 21:51:13 +0200 Subject: [PATCH] pkg/chunkenc: fix test using string(int) conversion Since go1.15, there's a new vet check for code such as string(x) where x has an integer type other than rune. This vet check is enabled by default on go test. TestSerialization failed because of that, this commit replaces `string()` conversions with `strconv.Itoa` calls Fixes #2646 --- pkg/chunkenc/memchunk_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/chunkenc/memchunk_test.go b/pkg/chunkenc/memchunk_test.go index f8b93057dbc1..d8c1b0a57fea 100644 --- a/pkg/chunkenc/memchunk_test.go +++ b/pkg/chunkenc/memchunk_test.go @@ -7,6 +7,7 @@ import ( "fmt" "math" "math/rand" + "strconv" "strings" "testing" "time" @@ -255,7 +256,7 @@ func TestSerialization(t *testing.T) { numSamples := 50000 for i := 0; i < numSamples; i++ { - require.NoError(t, chk.Append(logprotoEntry(int64(i), string(i)))) + require.NoError(t, chk.Append(logprotoEntry(int64(i), strconv.Itoa(i)))) } byt, err := chk.Bytes() @@ -271,7 +272,7 @@ func TestSerialization(t *testing.T) { e := it.Entry() require.Equal(t, int64(i), e.Timestamp.UnixNano()) - require.Equal(t, string(i), e.Line) + require.Equal(t, strconv.Itoa(i), e.Line) } require.NoError(t, it.Error())