From ddeb8df2e6c63d1994150a6afcd2d6f986a948d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Labesse=20K=C3=A9vin?= Date: Tue, 7 Jan 2020 09:35:54 +0100 Subject: [PATCH 1/3] : information about max_look_back_period --- docs/configuration/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/configuration/README.md b/docs/configuration/README.md index 114024282a91..b1e4284bdd2d 100644 --- a/docs/configuration/README.md +++ b/docs/configuration/README.md @@ -644,6 +644,8 @@ to wait before saving them to the backing store. [cache_lookups_older_than: ] # Limit how long back data can be queries. Default is disabled. +# If you configure `table_manager_config.retention_period` > 0 +# then you can set the same value here. [max_look_back_period: ] ``` From f9dbd6522904e76da235cc4bf58c22b10989a5e8 Mon Sep 17 00:00:00 2001 From: Kevin Labesse Date: Tue, 7 Jan 2020 15:25:59 +0100 Subject: [PATCH 2/3] update example --- docs/configuration/README.md | 4 ++-- docs/operations/storage/retention.md | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/configuration/README.md b/docs/configuration/README.md index b1e4284bdd2d..a9fd8afec2c0 100644 --- a/docs/configuration/README.md +++ b/docs/configuration/README.md @@ -644,8 +644,8 @@ to wait before saving them to the backing store. [cache_lookups_older_than: ] # Limit how long back data can be queries. Default is disabled. -# If you configure `table_manager_config.retention_period` > 0 -# then you can set the same value here. +# This should always be set to a value less than or equal to +# what is set in `table_manager.retention_period`. [max_look_back_period: ] ``` diff --git a/docs/operations/storage/retention.md b/docs/operations/storage/retention.md index 9c0c3c19954a..0ee9b9227422 100644 --- a/docs/operations/storage/retention.md +++ b/docs/operations/storage/retention.md @@ -57,6 +57,9 @@ storage_config: gcs: bucket_name: GCS_BUCKET_NAME +chunk_store_config: + max_look_back_period: 720h + table_manager: retention_deletes_enabled: true retention_period: 720h From 435e370c0be412f5f8ee39cd5abfe967a96af996 Mon Sep 17 00:00:00 2001 From: Sandeep Sukhani Date: Wed, 8 Jan 2020 13:08:01 +0530 Subject: [PATCH 3/3] added a note to retention doc and fixed a spell error --- docs/configuration/README.md | 2 +- docs/operations/storage/retention.md | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/configuration/README.md b/docs/configuration/README.md index a9fd8afec2c0..035a5d203a49 100644 --- a/docs/configuration/README.md +++ b/docs/configuration/README.md @@ -643,7 +643,7 @@ to wait before saving them to the backing store. # disabled. [cache_lookups_older_than: ] -# Limit how long back data can be queries. Default is disabled. +# Limit how long back data can be queried. Default is disabled. # This should always be set to a value less than or equal to # what is set in `table_manager.retention_period`. [max_look_back_period: ] diff --git a/docs/operations/storage/retention.md b/docs/operations/storage/retention.md index 0ee9b9227422..c84b463ab878 100644 --- a/docs/operations/storage/retention.md +++ b/docs/operations/storage/retention.md @@ -15,6 +15,10 @@ can be parsed using Go's [time.Duration](https://golang.org/pkg/time/#ParseDurat block. See the [Table Manager](./table-manager.md#retention) documentation for more information. +> **NOTE**: To avoid querying of data beyond the retention period, +`max_look_back_period` config in [`chunk_store_config`](../../configuration/README.md#chunk_store_config) must be set to a value less than or equal to +what is set in `table_manager.retention_period`. + When using S3 or GCS, the bucket storing the chunks needs to have the expiry policy set correctly. For more details check [S3's documentation](https://docs.aws.amazon.com/AmazonS3/latest/dev/object-lifecycle-mgmt.html)