You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
cmd/loki/Dockerfile currently fails to build due to the absence of goyacc in the golang image it is based on.
Example: https://drone.grafana.net/grafana/loki/8355/3/3
To fix this, grafana/loki-build-image should be used instead. It is based on the same golang docker image, but has the tools required by the Makefile included. It is already used in cmd/loki/Dockerfile.debug.
Unfortunately, even though a grafana/loki-build-image based container is able to invoke goyacc from make, it cannot build arm based images.
Example: https://drone.grafana.net/grafana/loki/8426/4/3
Describe the solution you'd like
CI based arm and arm64 support for the loki-build-image container.
Describe alternatives you've considered
As a temporary measure, I am creating a PR that introduces the go tools required to build loki into cmd/loki/Dockerfile.
This duplication is likely to cause drift if left in place too long, but will unblock me until grafana/loki-build-image can be ported to arm and arm64.
Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.
We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.
Stalebots are also emotionless and cruel and can close issues which are still very relevant.
If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.
We regularly sort for closed issues which have a stale label sorted by thumbs up.
We may also:
Mark issues as revivable if we think it's a valid issue but isn't something we are likely
to prioritize in the future (the issue will still remain closed).
Add a keepalive label to silence the stalebot if the issue is very common/popular/important.
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.
stalebot
added
the
stale
A stale issue or PR that will automatically be closed.
label
Apr 17, 2022
Is your feature request related to a problem? Please describe.
cmd/loki/Dockerfile currently fails to build due to the absence of goyacc in the golang image it is based on.
Example: https://drone.grafana.net/grafana/loki/8355/3/3
To fix this, grafana/loki-build-image should be used instead. It is based on the same golang docker image, but has the tools required by the Makefile included. It is already used in cmd/loki/Dockerfile.debug.
Unfortunately, even though a grafana/loki-build-image based container is able to invoke goyacc from make, it cannot build arm based images.
Example: https://drone.grafana.net/grafana/loki/8426/4/3
Describe the solution you'd like
CI based arm and arm64 support for the loki-build-image container.
Describe alternatives you've considered
As a temporary measure, I am creating a PR that introduces the go tools required to build loki into cmd/loki/Dockerfile.
This duplication is likely to cause drift if left in place too long, but will unblock me until grafana/loki-build-image can be ported to arm and arm64.
Additional context
#5323
#5306
#5275
The text was updated successfully, but these errors were encountered: