Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki Helm Chart document should support Helm 3 ? #1690

Closed
oke-py opened this issue Feb 13, 2020 · 3 comments · Fixed by #2038
Closed

Loki Helm Chart document should support Helm 3 ? #1690

oke-py opened this issue Feb 13, 2020 · 3 comments · Fixed by #2038
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@oke-py
Copy link
Contributor

oke-py commented Feb 13, 2020

Is your feature request related to a problem? Please describe.
Helm 3 is GA now and some command options changed from v2.
For example, the command below fails.

$ helm install stable/grafana -n loki-grafana
Error: must either provide a name or specify --generate-name

Describe the solution you'd like
The document below should be updated.
https://github.com/grafana/loki/tree/master/production/helm

Describe alternatives you've considered
I'm not sure which of Helm v2 or v3 should be mainly supported.

Additional context
N/A

@merqurio
Copy link

It works on Helm 3, the example fails because the -n argument was deprecated. Test this, it works for me:

helm install  loki-grafana stable/grafana

@oke-py
Copy link
Contributor Author

oke-py commented Feb 15, 2020

thx, but what I'd like to know is whether the document should be updated or not.

@stale
Copy link

stale bot commented Mar 16, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Mar 16, 2020
@stale stale bot closed this as completed Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants