From ede6941c6ff0f40d836b288e167a26c34c2a9437 Mon Sep 17 00:00:00 2001 From: Owen Diehl Date: Fri, 21 Jun 2024 13:52:11 -0700 Subject: [PATCH] fix(blooms): ignores bloom filtering errors in bounded shard query planning (#13285) --- pkg/indexgateway/gateway.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/indexgateway/gateway.go b/pkg/indexgateway/gateway.go index e2850e8c9317..7b49490a012e 100644 --- a/pkg/indexgateway/gateway.go +++ b/pkg/indexgateway/gateway.go @@ -465,12 +465,15 @@ func (g *Gateway) boundedShards( // 2) filter via blooms if enabled filters := syntax.ExtractLineFilters(p.Plan().AST) if g.bloomQuerier != nil && len(filters) > 0 { - filtered, err = g.bloomQuerier.FilterChunkRefs(ctx, instanceID, req.From, req.Through, refs, p.Plan()) + xs, err := g.bloomQuerier.FilterChunkRefs(ctx, instanceID, req.From, req.Through, refs, p.Plan()) if err != nil { - return err + level.Error(logger).Log("msg", "failed to filter chunk refs", "err", err) + } else { + filtered = xs } sp.LogKV( "stage", "queried bloom gateway", + "err", err, ) }