-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.1 Dataframe empty row #1303
Comments
Can you show me the code you are using to generate this Dataframe please. |
@pngwn |
Ah thanks. |
What is happening here is the dataframe is always respecting the |
Just to clarify, the default row_count is |
This seems like reasonable behavior to me for the Dataframe to initialize with the stated number of rows. What we need to do is implement a "delete row / delete column" functionality to address these kinds of situations |
This specific case is about whether the rows should match what comes back from the predict function or if it should respect the row count in that case as well. As an output the dataframe wouldn't have add/ delete functionality. Input and outputs aren't significantly different so what makes sense for an input doesn't always make sense for an output (although I'm not sure that is the case here) but we can modify the behaviour of static vs dynamic components. |
When the output Dataframe defaults to 3 lines, it will make users think that there is an illusion of outputting empty lines. |
Oh sorry I didn't read carefully. Going off of your comment @pngwn, what if we make the default # of rows be 0 or 1. We could do this for static dataframes only, but I don't see it being a problem for dynamic dataframes either (especially right now given that you can only add rows, not delete them). |
(sorry accidentally closed) |
Is there an existing issue for this?
Describe the bug
@pngwn
I am using gradio 3.0.1 and found that there is a problem with blank rows in Dataframe output: when the data is less than 3 rows, there are blank rows, as shown in the figure.
Reproduction
Screenshot
No response
Logs
No response
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: