Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add jacoco plugin to support code coverage #953

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

meltsufin
Copy link
Member

No description provided.

@meltsufin meltsufin requested review from a team as code owners February 24, 2022 14:50
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #953 (c6659c8) into main (de81617) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files         265      265           
  Lines       27632    27632           
  Branches     1203     1203           
=======================================
  Hits        25182    25182           
  Misses       2096     2096           
  Partials      354      354           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de81617...c6659c8. Read the comment docs.

<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.7</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to manage these plugins somewhere as well (shared deps?). Upper layers like handwritten libraries and boms should probably use the same setup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parent pom is usually a good place

Copy link
Contributor

@dangazineu dangazineu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meltsufin meltsufin merged commit 0bcb2d1 into main Feb 24, 2022
@meltsufin meltsufin deleted the jacoco-1 branch February 24, 2022 15:23
suztomo pushed a commit that referenced this pull request Mar 21, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jinja2](https://palletsprojects.com/p/jinja/) ([changelog](https://jinja.palletsprojects.com/changes/)) | `==3.0.3` -> `==3.1.2` | [![age](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/compatibility-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/confidence-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


## [2.8.17](googleapis/java-core@v2.8.16...v2.8.17) (2022-09-28)


### Dependencies

* Update dependency cachetools to v5 ([#943](googleapis/java-core#943)) ([1406c09](googleapis/java-core@1406c09))
* Update dependency certifi to v2022.9.24 ([#934](googleapis/java-core#934)) ([b6e1904](googleapis/java-core@b6e1904))
* Update dependency charset-normalizer to v2.1.1 ([#938](googleapis/java-core#938)) ([ac43d61](googleapis/java-core@ac43d61))
* Update dependency click to v8.1.3 ([#946](googleapis/java-core#946)) ([05fe31f](googleapis/java-core@05fe31f))
* Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.4 ([#945](googleapis/java-core#945)) ([3ebff6f](googleapis/java-core@3ebff6f))
* Update dependency gcp-releasetool to v1.8.8 ([#935](googleapis/java-core#935)) ([0f99ae1](googleapis/java-core@0f99ae1))
* Update dependency google-api-core to v2.10.1 ([#947](googleapis/java-core#947)) ([dedddfe](googleapis/java-core@dedddfe))
* Update dependency google-auth to v2.12.0 ([#948](googleapis/java-core#948)) ([67e53aa](googleapis/java-core@67e53aa))
* Update dependency google-cloud-core to v2.3.2 ([#936](googleapis/java-core#936)) ([a0d2e3e](googleapis/java-core@a0d2e3e))
* Update dependency google-cloud-storage to v2.5.0 ([#949](googleapis/java-core#949)) ([6edc6e3](googleapis/java-core@6edc6e3))
* Update dependency google-crc32c to v1.5.0 ([#950](googleapis/java-core#950)) ([0dda0a2](googleapis/java-core@0dda0a2))
* Update dependency googleapis-common-protos to v1.56.4 ([#937](googleapis/java-core#937)) ([b22a2b1](googleapis/java-core@b22a2b1))
* Update dependency importlib-metadata to v4.12.0 ([#951](googleapis/java-core#951)) ([6abe579](googleapis/java-core@6abe579))
* Update dependency jeepney to v0.8.0 ([#952](googleapis/java-core#952)) ([6a392e8](googleapis/java-core@6a392e8))
* Update dependency jinja2 to v3.1.2 ([#953](googleapis/java-core#953)) ([18a54a7](googleapis/java-core@18a54a7))
* Update dependency keyring to v23.9.3 ([#954](googleapis/java-core#954)) ([5ceabaa](googleapis/java-core@5ceabaa))
* Update dependency markupsafe to v2.1.1 ([#955](googleapis/java-core#955)) ([f64e9bf](googleapis/java-core@f64e9bf))
* Update dependency protobuf to v3.20.2 ([#956](googleapis/java-core#956)) ([fb1aea6](googleapis/java-core@fb1aea6))
* Update dependency protobuf to v4 ([#944](googleapis/java-core#944)) ([6b02535](googleapis/java-core@6b02535))
* Update dependency pyjwt to v2.5.0 ([#939](googleapis/java-core#939)) ([cc8ba46](googleapis/java-core@cc8ba46))
* Update dependency requests to v2.28.1 ([#940](googleapis/java-core#940)) ([ec195e3](googleapis/java-core@ec195e3))
* Update dependency typing-extensions to v4.3.0 ([#941](googleapis/java-core#941)) ([4c414e9](googleapis/java-core@4c414e9))
* Update dependency zipp to v3.8.1 ([#942](googleapis/java-core#942)) ([6dfb0d8](googleapis/java-core@6dfb0d8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants