Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor golden tests for autopopulation feature #2446

Merged
merged 11 commits into from
Feb 8, 2024
Merged

chore: refactor golden tests for autopopulation feature #2446

merged 11 commits into from
Feb 8, 2024

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Feb 7, 2024

As a clean-up follow up to #2353, this PR refactors the unit golden tests for the autopopulation feature to a separate, new proto called auto_populate_field_testing.proto.

@alicejli alicejli requested a review from a team as a code owner February 7, 2024 21:43
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Feb 7, 2024
@alicejli alicejli requested a review from lqiu96 February 8, 2024 14:39
@lqiu96
Copy link
Contributor

lqiu96 commented Feb 8, 2024

Can you also check if there should be goldens for ServiceStubClassComposerTest in grpcrest?

@lqiu96
Copy link
Contributor

lqiu96 commented Feb 8, 2024

Besides the two questions above, LGTM.

@alicejli
Copy link
Contributor Author

alicejli commented Feb 8, 2024

Can you also check if there should be goldens for ServiceStubClassComposerTest in grpcrest?

I've added in the goldens for them. Thanks!

@lqiu96
Copy link
Contributor

lqiu96 commented Feb 8, 2024

Can you also check if there should be goldens for ServiceStubClassComposerTest in grpcrest?

I've added in the goldens for them. Thanks!

I took a look at the grpc+rest composers and we don't think that the auto populate PR impacts those composers. We probably don't need goldens there, so you can remove those golden cases.

lqiu96
lqiu96 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you can make the two quick changes. Thanks!

@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alicejli alicejli merged commit 33ba423 into main Feb 8, 2024
25 checks passed
@alicejli alicejli deleted the refactorGoldenTests branch February 8, 2024 21:59
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 8, 2024
ddixit14 pushed a commit that referenced this pull request Feb 15, 2024
@alicejli @ddixit14
chore: refactor golden tests for autopopulation feature (#2446)
903c1f6 
As a clean-up follow up to
#2353, this PR
refactors the unit golden tests for the autopopulation feature to a
separate, new proto called `auto_populate_field_testing.proto`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alicejli @lqiu96