Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency com.googlecode.maven-download-plugin:download-maven-plugin to v1.7.1 #2151

Merged
merged 7 commits into from
Nov 28, 2023
Merged

deps: update dependency com.googlecode.maven-download-plugin:download-maven-plugin to v1.7.1 #2151

merged 7 commits into from
Nov 28, 2023

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 16, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.googlecode.maven-download-plugin:download-maven-plugin 1.6.8 -> 1.7.1 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

maven-download-plugin/maven-download-plugin (com.googlecode.maven-download-plugin:download-maven-plugin)

v1.7.1

Compare Source

What's Changed
New Contributors

Full Changelog: maven-download-plugin/maven-download-plugin@1.7.0...1.7.1

v1.7.0: [BROKEN] Replacing Maven 2 APIs with Maven 3

Compare Source

IMPORTANT

The release unintentionally breaks backward compatibility of internal cache
Please, DON'T USE IT

What's Changed
New Contributors

Full Changelog: maven-download-plugin/maven-download-plugin@1.6.8...1.7.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner October 16, 2023 19:35
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 16, 2023
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2023
@renovate-bot renovate-bot force-pushed the renovate/com.googlecode.maven-download-plugin-download-maven-plugin-1.x branch from baa96c2 to ef9fc43 Compare October 17, 2023 01:28
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2023
@renovate-bot renovate-bot force-pushed the renovate/com.googlecode.maven-download-plugin-download-maven-plugin-1.x branch from ef9fc43 to f664d35 Compare October 17, 2023 18:26
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2023
@lqiu96
Copy link
Contributor

lqiu96 commented Oct 18, 2023

Error:

Error:  Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.012 s <<< FAILURE! -- in com.google.showcase.v1beta1.it.ITHttpAnnotation
Error:  com.google.showcase.v1beta1.it.ITHttpAnnotation -- Time elapsed: 0.008 s <<< ERROR!
com.google.protobuf.InvalidProtocolBufferException: Expect message object but got: "\u001f�\b\u0000\u0000\u0000\u0000\u0000\u0000\u0003�XKo�6\u0010>ǿ�\u0010�K7���^\u0001zp\u001e�\u001a�ͦ��@"

Seems to be only affect the ITHttpAnnotation test. Might be due to how it's download the compliance_suit.json file from the gapic-showcase repo?

@lqiu96
Copy link
Contributor

lqiu96 commented Oct 18, 2023 •
edited
Loading

I'm unable to replicate this issue locally. Even after pulling this branch down and clean installing repo and running in the showcase module. Taking another look...

@renovate-bot renovate-bot force-pushed the renovate/com.googlecode.maven-download-plugin-download-maven-plugin-1.x branch from f664d35 to 7061430 Compare October 30, 2023 15:50
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 30, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 28, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Nov 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@forking-renovate Forking Renovate
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 28, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Nov 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 28, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Nov 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lqiu96 lqiu96 merged commit cbe1bb1 into googleapis:main Nov 28, 2023
21 checks passed
@release-please release-please bot mentioned this pull request Nov 28, 2023
Merged
@mpeddada1 mpeddada1 mentioned this pull request Nov 29, 2023
Closed
mpeddada1 added a commit that referenced this pull request Nov 29, 2023
@mpeddada1
Revert "deps: update dependency com.googlecode.maven-download-plugin:…
1368c9b 
…download-maven-plugin to v1.7.1 (#2151)"

This reverts commit cbe1bb1.
@mpeddada1 mpeddada1 mentioned this pull request Nov 29, 2023
Merged
mpeddada1 added a commit that referenced this pull request Nov 29, 2023
@mpeddada1
Revert "deps: update dependency com.googlecode.maven-download-plugin:…
7beaccf 
…download-maven-plugin to v1.7.1" (#2271)

* Revert "deps: update dependency com.googlecode.maven-download-plugin:download-maven-plugin to v1.7.1 (#2151)"
lqiu96 pushed a commit that referenced this pull request Dec 6, 2023
@mpeddada1 @lqiu96
Revert "deps: update dependency com.googlecode.maven-download-plugin:…
76acfa6 
…download-maven-plugin to v1.7.1" (#2271)

* Revert "deps: update dependency com.googlecode.maven-download-plugin:download-maven-plugin to v1.7.1 (#2151)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renovate-bot @lqiu96 @mpeddada1 @yoshi-kokoro